[asterisk-bugs] [JIRA] (ASTERISK-21042) pbx_spool: callfile variables overriding/lost in __ast_request_and_dial()

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=202930#comment-202930 ] 

Matt Jordan commented on ASTERISK-21042:
----------------------------------------

Hm. I might need to understand a bit more of the use case and where this behavior goes awry.
# The fact that the parent channel's variables override the outgoing handler's variables might be what some people expect and want. I don't feel that I know enough about the expected behavior and the places it can be used to justify changing the behavior.
# The second does feel more like an issue, but I'm not sure how the ast_set_variables call coming after the setting of the connect line information changes this. What variable are you setting in the outgoing handler that is overriding the connected line information?

                
> pbx_spool: callfile variables overriding/lost in __ast_request_and_dial()
> -------------------------------------------------------------------------
>
>                 Key: ASTERISK-21042
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21042
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/Channels, PBX/pbx_spool
>    Affects Versions: 1.8.20.1
>            Reporter: Roman S.
>            Severity: Trivial
>         Attachments: originate-vars-fix.diff
>
>
> {{__ast_request_and_dial()}} calls {{ast_set_variables(chan, oh->vars)}} before {{ast_channel_inherit_variables(oh->parent_channel, chan)}} and before {{ast_channel_set_connected_line(chan, &connected, NULL)}}. It causes:
>  1. overriding of some variables from oh struct with values from parent channel (if any)
>  2. overriding/ignore of {{CONNECTEDLINE()}} function job from callfile
> I suppose to call {{ast_set_variables(chan, oh->vars)}} just after {{ast_channel_set_connected_line(chan, &connected, NULL)}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira