[asterisk-bugs] [JIRA] (ASTERISK-21042) pbx_spool: callfile variables overriding/lost in __ast_request_and_dial()

[Roman S. (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-21042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman S. updated ASTERISK-21042:
--------------------------------

    Description: 
{{__ast_request_and_dial()}} calls {{ast_set_variables(chan, oh->vars)}} before {{ast_channel_inherit_variables(oh->parent_channel, chan)}} and before {{ast_channel_set_connected_line(chan, &connected, NULL)}}. It causes:
 1. overriding of some variables from oh struct with values from parent channel (if any)
 2. overriding/ignore of {{CONNECTEDLINE()}} function job from callfile
I suppose to call {{ast_set_variables(chan, oh->vars)}} just after {{ast_channel_set_connected_line(chan, &connected, NULL)}}.

  was:
__ast_request_and_dial() calls ast_set_variables(chan, oh->vars) before ast_channel_inherit_variables(oh->parent_channel, chan) and before ast_channel_set_connected_line(chan, &connected, NULL). It causes:
 1. overriding of some variables from oh struct with values from parent channel (if any)
 2. overriding/ignore of CONNECTEDLINE() function job from callfile
I suppose to call ast_set_variables(chan, oh->vars) just after ast_channel_set_connected_line(chan, &connected, NULL).

    
> pbx_spool: callfile variables overriding/lost in __ast_request_and_dial()
> -------------------------------------------------------------------------
>
>                 Key: ASTERISK-21042
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21042
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/Channels, PBX/pbx_spool
>    Affects Versions: 1.8.20.1
>            Reporter: Roman S.
>            Severity: Trivial
>         Attachments: originate-vars-fix.diff
>
>
> {{__ast_request_and_dial()}} calls {{ast_set_variables(chan, oh->vars)}} before {{ast_channel_inherit_variables(oh->parent_channel, chan)}} and before {{ast_channel_set_connected_line(chan, &connected, NULL)}}. It causes:
>  1. overriding of some variables from oh struct with values from parent channel (if any)
>  2. overriding/ignore of {{CONNECTEDLINE()}} function job from callfile
> I suppose to call {{ast_set_variables(chan, oh->vars)}} just after {{ast_channel_set_connected_line(chan, &connected, NULL)}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira