[asterisk-bugs] [JIRA] (ASTERISK-20742) [patch] Log callers entering/leaving MOH.

[Steve Murphy (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=200189#comment-200189 ] 

Steve Murphy commented on ASTERISK-20742:
-----------------------------------------

Now, as to the spread of knowledge about app_queue. I was concerned about this myself. In my research, I discovered that
the queue_log function is defined in main/logger.c; queue_log is called from (besides app_queue.c) chan_agent.c; and
with this patch, also in res_musiconhold.c.

So, knowing that the added code depends on functionality provided in the core (main) of asterisk, and that app_queue
need not even be loaded, and no added dependencies are therefore created, I felt better.

I also pondered what it would take to keep the code purely inside app_queue, and it started getting messy with callbacks, and more files affected, that I gave up on the alternatives. Perhaps someone would like to spend the time?

For instance, it occurred to me that queue_log could be eradicated from the core entirely, in favor, say, of a CEL post processor generating it from the event stream. We'd have to be sure to generate all the queue events, and the post processor
would have to be written. I can guarantee that this would be a fair sized project, and yield little value over what exists already.

                
> [patch] Log callers entering/leaving MOH.
> -----------------------------------------
>
>                 Key: ASTERISK-20742
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20742
>             Project: Asterisk
>          Issue Type: New Feature
>      Security Level: None
>          Components: Applications/app_queue
>    Affects Versions: SVN, 12
>         Environment: all
>            Reporter: Steve Murphy
>            Severity: Trivial
>         Attachments: qonhold.trunk.diff, qonholdv2.trunk.diff
>
>
> This patch will allow incoming calls to track the time they are put on hold (MOH). This does not count MOH played before an agent accepts the call.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira