[asterisk-bugs] [DAHDI-linux 0018604]: [patch] fails to compile against kernel 2.6.37 without CONFIG_BKL

Asterisk Bug Tracker noreply at bugs.digium.com
Wed Jan 12 13:25:54 CST 2011


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18604 
====================================================================== 
Reported By:                jkroon
Assigned To:                
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   18604
Category:                   dahdi (the module)
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     acknowledged
JIRA:                       DAHDI-752 
Reviewboard Link:            
====================================================================== 
Date Submitted:             2011-01-12 07:28 CST
Last Modified:              2011-01-12 13:25 CST
====================================================================== 
Summary:                    [patch] fails to compile against kernel 2.6.37
without CONFIG_BKL
Description: 
dahdi-linux refuses to compile against the 2.6.37 kernel unless CONFIG_BKL
is set.  CONFIG_BKL is set to die very soon.
====================================================================== 

---------------------------------------------------------------------- 
 (0130426) sruffell (administrator) - 2011-01-12 13:25
 https://issues.asterisk.org/view.php?id=18604#c130426 
---------------------------------------------------------------------- 
Well...ok "movement" was a little strong. :)    Since CONFIG_BKL will
probably still remain the default for a few more kernel cycles, if you want
to modify your "unlocked" patch to only remove the lock_kernel if
CONFIG_BKL is not defined, and add some protection around at least the
global dialparams, then I don't have a problem committing it right now. 
Then a full audit, etc.. can be done when all remnants of "lock_kernel()"
is removed.

What do you think about that?  Also, if you use git, feel free to attach
the patch with git then that way you can write the commit message (and your
email address can go into the commit).  If you don't use git....no sweat. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-12 13:25 sruffell       Note Added: 0130426                          
======================================================================




More information about the asterisk-bugs mailing list