[asterisk-bugs] [DAHDI-linux 0018604]: [patch] fails to compile against kernel 2.6.37 without CONFIG_BKL

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18604 
====================================================================== 
Reported By:                jkroon
Assigned To:                
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   18604
Category:                   dahdi (the module)
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     acknowledged
JIRA:                       DAHDI-752 
Reviewboard Link:            
====================================================================== 
Date Submitted:             2011-01-12 07:28 CST
Last Modified:              2011-01-12 12:52 CST
====================================================================== 
Summary:                    [patch] fails to compile against kernel 2.6.37
without CONFIG_BKL
Description: 
dahdi-linux refuses to compile against the 2.6.37 kernel unless CONFIG_BKL
is set.  CONFIG_BKL is set to die very soon.
====================================================================== 

---------------------------------------------------------------------- 
 (0130425) jkroon (reporter) - 2011-01-12 12:52
 https://issues.asterisk.org/view.php?id=18604#c130425 
---------------------------------------------------------------------- 
Attached both my patches anyway.  I haven't had any obvious issues on 2.4.0
on a range of BRI, PRI and TDM400, 800 or 2400 cards without CONFIG_BKL and
got a number of machines where it's working properly.  For that reason I
believe the -unlocked variant of the patch should be OK, alternatively the
-locked version should be good enough to drop the dependency on the BKL
from the code.

I believe Digium has a battery of regression tests that it can throw at
the modules and I myself have what I call the monkey test I can use that'll
do a few million call setups + teardowns in relatively short order (using
multiple PRI and BRI loops).

The "movement" you mention seems to be mostly documentation indicating
that it'll be annoying on >2.6.37 kernels, this provides actual code
patches which I hope will be useful.

Please note that without CONFIG_BKL in pre 2.6.37, lock_kernel and
unlock_kernel seems to be no-op operations anyway, so on all my systems
(quite a few with kernels ranging from 2.6.30 through to 2.6.37) it seems
to be OK.  Obviously I could just have been insanely lucky so far. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-12 12:52 jkroon         Note Added: 0130425                          
======================================================================