[asterisk-bugs] [Asterisk 0018729]: [patch] [regression] Dial() and Queue() with a macro argument are broken by AEL macro compilation change

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18729 
====================================================================== 
Reported By:                kkm
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18729
Category:                   PBX/pbx_ael
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.8.3-rc2 
JIRA:                       SWP-3052 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-02-02 04:15 CST
Last Modified:              2011-02-09 01:08 CST
====================================================================== 
Summary:                    [patch] [regression] Dial() and Queue() with a macro
argument are broken by AEL macro compilation change
Description: 
Macros used to compile using 's' as the entry point, and that changed to
'~~s~~'. The change broke the macro argument to Dial and Queue
applications.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018480 [patch] Contexts with a 'switch' statem...
====================================================================== 

---------------------------------------------------------------------- 
 (0131718) kkm (reporter) - 2011-02-09 01:08
 https://issues.asterisk.org/view.php?id=18729#c131718 
---------------------------------------------------------------------- 
I am afraid this patch did not fix it.

Queue (SomeQueue,,,,600,,,on-queue-answer)
 . . .
macro originate-on-queue-answer() {
}

gives this:

[2011-02-08 22:44:23.996] ERROR[26040]: app_stack.c:419 gosub_exec:
Attempt to reach a non-existent destination for gosub:
(Context:originate-on-queue-answer, Extension:s, Priority:1)

and after the queue is answered,

[2011-02-08 22:45:01.876] WARNING[26042]: pbx.c:4812 __ast_pbx_run:
Channel 'SIP/netborder-out-00000001' sent into invalid extension '~~s~~' in
context 'app_dial_gosub_virtual_context', but no invalid handler

The extension in context in the context created by the Queue app,
app_dial_gosub_virtual_context, is always "s". So this is not right:

+ ast_copy_string(peer->exten, "~~s~~", sizeof(peer->exten));

Also, what_is_s was not used in app_queue when forming a GoSub argument,
as it was in app_dial.

I am attaching a new diff with these changes; does it look correct? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-09 01:08 kkm            Note Added: 0131718                          
======================================================================