[asterisk-bugs] [Asterisk 0018280]: EID is not copied when event is received from XMPP and forwarded into Asterisk's core
Asterisk Bug Tracker
noreply at bugs.digium.com
Fri Nov 19 18:50:01 CST 2010
A NOTE has been added to this issue.
======================================================================
https://issues.asterisk.org/view.php?id=18280
======================================================================
Reported By: klaus3000
Assigned To: russell
======================================================================
Project: Asterisk
Issue ID: 18280
Category: Resources/res_jabber
Reproducibility: always
Severity: minor
Priority: normal
Status: closed
Asterisk Version: 1.8.0
JIRA:
Regression: No
Reviewboard Link:
SVN Branch (only for SVN checkouts, not tarball releases): N/A
SVN Revision (number only!):
Request Review:
Resolution: fixed
Fixed in Version:
======================================================================
Date Submitted: 2010-11-08 17:20 CST
Last Modified: 2010-11-19 18:50 CST
======================================================================
Summary: EID is not copied when event is received from XMPP
and forwarded into Asterisk's core
Description:
see
http://lists.digium.com/pipermail/asterisk-dev/2010-November/046898.html
and
http://lists.digium.com/pipermail/asterisk-dev/2010-November/046914.html
======================================================================
Relationships ID Summary
----------------------------------------------------------------------
related to 0018284 [patch] devicestate is not aggregated f...
======================================================================
----------------------------------------------------------------------
(0129006) svnbot (reporter) - 2010-11-19 18:50
https://issues.asterisk.org/view.php?id=18280#c129006
----------------------------------------------------------------------
Repository: asterisk
Revision: 295711
_U branches/1.8/
U branches/1.8/include/asterisk/event.h
U branches/1.8/main/event.c
------------------------------------------------------------------------
r295711 | russell | 2010-11-19 18:50:00 -0600 (Fri, 19 Nov 2010) | 36
lines
Merged revisions 295710 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r295710 | russell | 2010-11-19 18:45:51 -0600 (Fri, 19 Nov 2010) | 29
lines
Fix cache of device state changes for multiple servers.
This patch addresses a regression where device states across multiple
servers
were not being processing completely correctly. The code works to
determine
the overall state by looking at the last known state of a device on each
server. However, there was a regression due to some invasive rewrites
of how
the cache works that led to the cache only storing the last device state
change
for a device, regardless of which server it was on.
The code is set up to cache device state change events by ensuring that
each
event in the cache has a unique device name + entity ID (server ID).
The code
that was responsible for comparing raw information elements (which EID
is)
always returned a match due to a memcmp() with a length of 0.
There isn't much code to fix the actual bug. This patch also introduces
a new
CLI command that was very useful for debugging this problem. The
command
allows you to dump the contents of the event cache.
(closes issue https://issues.asterisk.org/view.php?id=18284)
Reported by: klaus3000
Patches:
issue18284.rev1.txt uploaded by russell (license 2)
Tested by: russell, klaus3000
(closes issue https://issues.asterisk.org/view.php?id=18280)
Reported by: klaus3000
Review: https://reviewboard.asterisk.org/r/1012/
........
------------------------------------------------------------------------
http://svn.digium.com/view/asterisk?view=rev&revision=295711
Issue History
Date Modified Username Field Change
======================================================================
2010-11-19 18:50 svnbot Checkin
2010-11-19 18:50 svnbot Note Added: 0129006
======================================================================
More information about the asterisk-bugs
mailing list