[asterisk-bugs] [Asterisk 0016230]: [patch] g726 to g726aal2 translation and cost-calculation are wrong but easily fixed.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16230 
====================================================================== 
Reported By:                jonconsi
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16230
Category:                   Codecs/codec_g726
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
JIRA:                       SWP-787 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 229607 
Request Review:              
====================================================================== 
Date Submitted:             2009-11-12 07:09 CST
Last Modified:              2010-01-26 20:13 CST
====================================================================== 
Summary:                    [patch] g726 to g726aal2 translation and
cost-calculation are wrong but easily fixed.
Description: 
As detailed in Issue 15504, sometimes Asterisk incorrectly calculates that
it is lower-cost to go from g726->g726AAL2->linear instead of directly from
g726->linear. This exposed a bug in the g726->g726AAL2 (or vice-versa)
translation, which is a simple nybble re-ordering. This bug gives rise to
badly distorted and choppy audio.

The fix given in 15504 was to delete the g726->g726AAL2 translation but
this is unneccessary.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015504 [patch] G726 Codec has choppy audio on ...
====================================================================== 

---------------------------------------------------------------------- 
 (0117226) globalnetinc (reporter) - 2010-01-26 20:13
 https://issues.asterisk.org/view.php?id=16230#c117226 
---------------------------------------------------------------------- 
does not patch correctly and does not compile on 1.6.2.1

codec_g726.c: In function âg726tolin_sampleâ:
codec_g726.c:793: error: âg726_slin_exâ undeclared (first use in this
function)
codec_g726.c:793: error: (Each undeclared identifier is reported only
once
codec_g726.c:793: error: for each function it appears in.)
codec_g726.c: In function âlintog726_sampleâ:
codec_g726.c:807: error: âslin_g726_exâ undeclared (first use in this
function) 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-26 20:13 globalnetinc   Note Added: 0117226                          
======================================================================