[asterisk-bugs] [Asterisk 0017870]: [patch] greetingsfolder variable should be greetingfolder

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17870 
====================================================================== 
Reported By:                edhorton
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17870
Category:                   Applications/app_voicemail/IMAP
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.6.2.11 
JIRA:                       SWP-2056 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-08-16 11:46 CDT
Last Modified:              2010-08-16 16:54 CDT
====================================================================== 
Summary:                    [patch] greetingsfolder variable should be
greetingfolder
Description: 
The variable to choose an IMAP location for the greetings is referred to in
voicemail.conf and other documentation as "greetingsfolder".  In
app_voicemail.c, this variable is defined as "greetingfolder".  the "s" is
omitted.  If greetingsfolder is used, asterisk correctly defaults to INBOX.
====================================================================== 

---------------------------------------------------------------------- 
 (0126001) edhorton (reporter) - 2010-08-16 16:54
 https://issues.asterisk.org/view.php?id=17870#c126001 
---------------------------------------------------------------------- 
I tried it, but I think the first part of the patch should be:
+		if (!ast_strlen_zero(greetingsfolder)) {
+			snprintf(spec, len, "%s%s", tmp, greetingsfolder);
+		} else {

I added the "s".

With this now both greetingfolder and greetingsfolder both work correctly
for message retrieval and playback.

I did try recording a new greeting, and it always writes the message to
INBOX but removes it from the Greetings folder.  I changed the IMAP server
from maildir format to mbox and there was no difference.  Before I thought
it worked correcly in mbox format but had seen this operation with maildir
format.  I described this in another issue (0017871).  Maybe I was wrong
about the mbox format before.  I will dig further. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-16 16:54 edhorton       Note Added: 0126001                          
======================================================================