[asterisk-bugs] [Asterisk 0017633]: (Regression) Pickup from Grandstream BLF button ignores the context specified in Pickup command

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17633 
====================================================================== 
Reported By:                urosh
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   17633
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Target Version:             1.6.2.12
Asterisk Version:           SVN 
JIRA:                       SWP-1852 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-07-13 05:22 CDT
Last Modified:              2010-08-12 17:17 CDT
====================================================================== 
Summary:                    (Regression) Pickup from Grandstream BLF button
ignores the context specified in Pickup command
Description: 
Hi i had problem described in this issue: 
https://issues.asterisk.org/view.php?id=17120
asterisk error was:

[Mar 30 09:48:26] NOTICE[30223]: chan_sip.c:19860 handle_request_invite:
Trying to pick up 520 at blf
[Mar 30 09:48:27] NOTICE[30223]: chan_sip.c:19860 handle_request_invite:
Trying to pick up 520 at blf
[Mar 30 09:48:27] NOTICE[30223]: app_directed_pickup.c:257 pickup_exec: No
target channel found for 520.

I managed to correct it with removing p->callid in line 11302.
I am not a programmer of c++ so I am attaching corrected lines, that
worked for me.

Now phone works like in version 1.6.1, where phone on blinking BLF called
**EXTEN.


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014567 Directed call pickup does not work usin...
related to          0017671 Fetching Call with Grandstream-BLF (**$...
related to          0017120 (Regression) Pickup from Grandstream BL...
====================================================================== 

---------------------------------------------------------------------- 
 (0125929) alecdavis (manager) - 2010-08-12 17:17
 https://issues.asterisk.org/view.php?id=17633#c125929 
---------------------------------------------------------------------- 
urosh: correct, your change to chan_sip causes the old behaviour, the BLF
button won't do a subscripition based pickup, it will cause the pickup to
use the dialplan, and as it's going through the dialplan, the HOLD and
TRANSFER work.

But using the subscription based pickup, 'magic_pickup' as referred to in
code, thats when you'll later have problems with HOLD and TRANSFER.

What works for us without using the PICKMARK, is that the blf hints and
the phone's context have to be the same.

<pre>test*CLI> sip show subscriptions
Peer             User             Call ID          Extension        Last
state     Type            Mailbox    Expiry
192.168.5.141    GXP0001          b35a38dcf3bee94  8626 at trusted     InUse 
        dialog-info+xml <none>     000300
192.168.5.129    GXP0013          4a3f410f48d195a  8612 at trusted     Idle  
        dialog-info+xml <none>     003600
2 active SIP subscriptions
test*CLI> core show hints

    -= Registered Asterisk Dial Plan Hints =-
                   8626 at trusted             : SIP/GXP0013          
State:InUse           Watchers  1
                   8612 at trusted             : SIP/GXP0001          
State:Idle            Watchers  1</pre> 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-12 17:17 alecdavis      Note Added: 0125929                          
======================================================================