[asterisk-bugs] [Asterisk 0017824]: [regression] After 1.6.2.8 the #include directive does not work if missing closing double quote

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17824 
====================================================================== 
Reported By:                Micc
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17824
Category:                   Core/Configuration
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.2.10 
JIRA:                       SWP-2029 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-08-10 00:19 CDT
Last Modified:              2010-08-12 17:01 CDT
====================================================================== 
Summary:                    [regression] After 1.6.2.8 the #include directive
does not work if missing closing double quote
Description: 
As soon as I started 1.6.2.10 I noticed my dialplan reload was not a valid
command and a fraction of my dialplan existed. Dialplan show ? only showed
some of the contexts in my extensions.conf. I use a lot of includes and I
have a lot of lines that are commented out spacers of dashes and
underscores like
;--------------------------------------------------------------------
#include "mydir/macros.conf"
;____________________________________________________________________

I also have a lot of nested include files. I had to down grade to 1.6.2.8
which worked fine with the same files. I tried a second time with a fresh
1.6.2.10 source tree with the same results.
====================================================================== 

---------------------------------------------------------------------- 
 (0125928) Micc (reporter) - 2010-08-12 17:01
 https://issues.asterisk.org/view.php?id=17824#c125928 
---------------------------------------------------------------------- 
I agree with that. As long as its going to be obvious enough as soon as
someone starts asterisk. If its starting in the background though they
might not see it until its reloaded, which doesn't seem to be available in
this case for some reason, maybe theres another bug here as well. Someone
would have to look in the asterisk log file messages to see the warning.
Which still kind of makes me think it might be nice to have a fall back
behavior. It doesn't seem to cause any other problems, but I'm ok with just
having a warning and also a big note somewhere in a readme or release notes
about this change so people don't get screwed. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-12 17:01 Micc           Note Added: 0125928                          
======================================================================