[asterisk-bugs] [Asterisk 0016168]: Hold Time report (reportholdtime) issue

[Asterisk Bug Tracker]

The following issue requires your FEEDBACK. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16168 
====================================================================== 
Reported By:                nickilo
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16168
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.1.5 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-11-02 17:23 CST
Last Modified:              2009-11-04 09:19 CST
====================================================================== 
Summary:                    Hold Time report (reportholdtime) issue
Description: 
When reporting hold time, 

the number of second has to be modulo 60 otherwise the announce can be :
2 minutes 123 seconds instead of 2 minutes 3 seconds

Additionnally the file queue-minute does not exist.

I hope i'm clear enough.

I propose to do the following changes to /apps/app_queue.c :

at line 4187 : change holdtimesecs = abs((now - qe->start)); TO
holdtimesecs = abs((now - qe->start)%60);

at line 4190 : change play_file(peer, qe->parent->sound_minute); TO
play_file(peer, qe->parent->sound_minutes);


Thank You

====================================================================== 

---------------------------------------------------------------------- 
 (0113115) lmadsen (administrator) - 2009-11-04 09:19
 https://issues.asterisk.org/view.php?id=16168#c113115 
---------------------------------------------------------------------- 
Actually, you need to create the patches as unified diffs.

If you checked out from SVN, and made changes there, then you can just
do:

svn diff > patch-trunk.txt

Or you can use:  diff -u

if using separate files. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-04 09:19 lmadsen        Note Added: 0113115                          
2009-11-04 09:19 lmadsen        Status                   acknowledged =>
feedback
======================================================================