[asterisk-bugs] [Asterisk 0014253]: [patch] app_voicemail leaves sockets in close wait.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14253 
====================================================================== 
Reported By:                Skavin
Assigned To:                Corydon76
====================================================================== 
Project:                    Asterisk
Issue ID:                   14253
Category:                   Applications/app_voicemail/IMAP
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.4.21.1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-15 15:23 CST
Last Modified:              2009-02-08 22:50 CST
====================================================================== 
Summary:                    [patch] app_voicemail leaves sockets in close wait.
Description: 
app_voicemail is not closing imap sockets and they are going into
CLOSE_WAIT.
I am using imap-2006j
open files seem to go up during busy times but never drop.
my asterisk-vm process does not notify it is only there to isolate
recording and playback of voice mail from the rest of asterisk.
my asterisk process forwards to asterisk-vm in the case of busy/noanswer
or checking voicemail.
in 50 hours I have generated 
836 handles in CLOSE_WAIT all to imap
33 handles in ESTABLISHED 1 mysql 32 imap
12 udp handles
====================================================================== 

---------------------------------------------------------------------- 
 (0099676) Skavin (reporter) - 2009-02-08 22:50
 http://bugs.digium.com/view.php?id=14253#c99676 
---------------------------------------------------------------------- 
tryed to apply your patch to 1.4 and got this error
   [CC] app_voicemail.c -> app_voicemail.o
In file included from
/usr/src/ray/asterisk-1.4.21.2/imap-2007e/c-client/osdep.h:63,
                 from
/usr/src/ray/asterisk-1.4.21.2/imap-2007e/c-client/c-client.h:42,
                 from app_voicemail.c:82:
/usr/src/ray/asterisk-1.4.21.2/imap-2007e/c-client/env_unix.h:71: warning:
function declaration isn’t a prototype
app_voicemail.c:126: warning: data definition has no type or storage
class
app_voicemail.c:126: warning: type defaults to ‘int’ in declaration of
‘AST_THREADSTORAGE’
app_voicemail.c:126: warning: parameter names (without types) in function
declaration
app_voicemail.c: In function ‘create_vm_state_from_user’:
app_voicemail.c:1902: error: ‘ts_vmstate’ undeclared (first use in
this function)
app_voicemail.c:1902: error: (Each undeclared identifier is reported only
once
app_voicemail.c:1902: error: for each function it appears in.)
app_voicemail.c: In function ‘get_vm_state_by_imapuser’:
app_voicemail.c:1928: error: ‘ts_vmstate’ undeclared (first use in
this function)
app_voicemail.c: In function ‘get_vm_state_by_mailbox’:
app_voicemail.c:1968: error: ‘ts_vmstate’ undeclared (first use in
this function)
app_voicemail.c: In function ‘vm_execmain’:
app_voicemail.c:7350: error: ‘ts_vmstate’ undeclared (first use in
this function)
make[1]: *** [app_voicemail.o] Error 1
make[1]: Leaving directory `/usr/src/svn/asterisk-svn-1.4.23.1/apps'
make: *** [apps] Error 2

added #include "asterisk/threadstorage.h"
and got this error
In file included from
/usr/src/ray/asterisk-1.4.21.2/imap-2007e/c-client/osdep.h:63,
                 from
/usr/src/ray/asterisk-1.4.21.2/imap-2007e/c-client/c-client.h:42,
                 from app_voicemail.c:82:
/usr/src/ray/asterisk-1.4.21.2/imap-2007e/c-client/env_unix.h:71: warning:
function declaration isn’t a prototype
app_voicemail.c:127:29: error: macro "AST_THREADSTORAGE" requires 2
arguments, but only 1 given
app_voicemail.c:127: warning: data definition has no type or storage
class
app_voicemail.c:127: warning: type defaults to ‘int’ in declaration of
‘AST_THREADSTORAGE’
app_voicemail.c: In function ‘create_vm_state_from_user’:
app_voicemail.c:1903: error: ‘ts_vmstate’ undeclared (first use in
this function)
app_voicemail.c:1903: error: (Each undeclared identifier is reported only
once
app_voicemail.c:1903: error: for each function it appears in.)


thoughts? should there be a ts_vmstate_init? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-08 22:50 Skavin         Note Added: 0099676                          
======================================================================