[asterisk-bugs] [Asterisk 0014227]: queue-thankyou should be played only if needed

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14227 
====================================================================== 
Reported By:                caspy
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   14227
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
Target Version:             1.6.2
Asterisk Version:           1.6.0.3-rc1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-13 07:27 CST
Last Modified:              2009-02-03 09:43 CST
====================================================================== 
Summary:                    queue-thankyou should be played only if needed
Description: 
In say_position() in app_queue.c there is a command to play
'queue-thankyou' sound:
  res = play_file(qe->chan, qe->parent->sound_thanks);

This sound is played unconditionally, but should be played only in case if
position or holdtime was played.
Current code is generating 'queue-thankyou' without anything else, for
example, in case of position turned off + holdtime turned on, and hold time
less than a 1 minute.
====================================================================== 

---------------------------------------------------------------------- 
 (0099340) caspy (reporter) - 2009-02-03 09:43
 http://bugs.digium.com/view.php?id=14227#c99340 
---------------------------------------------------------------------- 
Tested. 

Now, in case of turned ON holdtime announce and holdtime == 00:00,
we have a 'queue-thankyou' sound played without(!) holdtime announce.
It's not good.

So, i have a suggestion: wrap playing of 'queue-thankyou' like this:
if ( !((avgholdmins+avgholdsecs) = 0 && qe->parent->announceholdtime) ) {
  res = play_file(qe->chan, qe->parent->sound_thanks);
}

and after this current logic will be just the same:
- in case of turned OFF holdtime announcement, 'queue-thankyou' always
played;
- in case of turned ON holdtime announcement and holdtime>0, holdtime and
'queue-thankyou' played together;
- in case of turned ON holdtime announcement and holdtime=0, nothing
played (and it is good! 'queue-thankyou' should not be played too, cause
estimated holdtime is very-very low. it is useless and annoying). 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-02-03 09:43 caspy          Note Added: 0099340                          
======================================================================