[asterisk-bugs] [Asterisk 0013710]: [patch] MWI NOTIFY always tries to use UDP, even if the peer is connected via TCP

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13710 
====================================================================== 
Reported By:                andrew53
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   13710
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 149637 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-15 13:05 CDT
Last Modified:              2008-10-21 18:17 CDT
====================================================================== 
Summary:                    [patch] MWI NOTIFY always tries to use UDP, even if
the peer is connected via TCP
Description: 
When sip_send_mwi_to_peer creates temporary dialog to send MWI notification
to peer, it doesn't reset p->socket.type, which results in subsequent
create_addr_from_peer failing (it thinks that dialog is using UDP, when the
peer uses TCP) and cancelling the attempt to send the notification.
====================================================================== 

---------------------------------------------------------------------- 
 (0094111) svnbot (reporter) - 2008-10-21 18:17
 http://bugs.digium.com/view.php?id=13710#c94111 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 151428

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r151428 | mmichelson | 2008-10-21 18:17:03 -0500 (Tue, 21 Oct 2008) | 14
lines

If a peer uses any transport other than UDP, then MWI will
fail for that peer since sip_alloc will allocate a sip_pvt with
a default transport of UDP. This change resets the socket type
immediately after allocating the sip_pvt in sip_send_mwi_from_peer,
so that the proceeding call to create_addr_from_peer does not fail
right away. The socket data from the peer is properly copied to
the sip_pvt in create_addr_from_peer.

(closes issue http://bugs.digium.com/view.php?id=13710)
Reported by: andrew53
Patches:
      sip_notify_use_tcp.patch uploaded by andrew53 (license 519)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=151428 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-21 18:17 svnbot         Checkin                                      
2008-10-21 18:17 svnbot         Note Added: 0094111                          
======================================================================