[asterisk-bugs] [Asterisk 0013710]: [patch] MWI NOTIFY always tries to use UDP, even if the peer is connected via TCP

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13710 
====================================================================== 
Reported By:                andrew53
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   13710
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 149637 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-15 13:05 CDT
Last Modified:              2008-10-21 18:11 CDT
====================================================================== 
Summary:                    [patch] MWI NOTIFY always tries to use UDP, even if
the peer is connected via TCP
Description: 
When sip_send_mwi_to_peer creates temporary dialog to send MWI notification
to peer, it doesn't reset p->socket.type, which results in subsequent
create_addr_from_peer failing (it thinks that dialog is using UDP, when the
peer uses TCP) and cancelling the attempt to send the notification.
====================================================================== 

---------------------------------------------------------------------- 
 (0094110) putnopvut (administrator) - 2008-10-21 18:11
 http://bugs.digium.com/view.php?id=13710#c94110 
---------------------------------------------------------------------- 
I was looking at the patch and thinking, "Wouldn't it make more sense to
just copy the peer socket data over to the sip_pvt instead of just setting
the sip_pvt's socket type to 0?" But then I saw that that is exactly what
happens in create_addr_from_peer right after the part that is failing. I'd
say that this patch should work fine, although I'm going to add a comment
noting that the socket data is copied in create_addr_from_peer.

Thanks for the patch! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-10-21 18:11 putnopvut      Note Added: 0094110                          
======================================================================