[asterisk-bugs] [Asterisk 0010297]: [patch] Unload/load support for chan_skinny

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10297 
====================================================================== 
Reported By:                DEA
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10297
Category:                   Channels/chan_skinny/NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.0-beta8 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 76940 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2007-07-25 01:40 CDT
Last Modified:              2008-11-23 01:35 CST
====================================================================== 
Summary:                    [patch] Unload/load support for chan_skinny
Description: 
Reload is not working, but unload and load do work.
My reload code is ugly-simple, it calls the unload 
function, then the load function.  I would have thought
if I could manually unload and load that would be enough.


My threading knowledge is more than a bit weak, but the
existing code was 90% there already.  We needed to store
the address of the skinny_session thread launch from within
accept_thread so we could later cancel it.

Interestingly the skinnysession structure had a member to
store the thread address, but it did not appear to be used.

I also move the teardown of the accept thread to a point before
tearing down the sessions (and their threads) to prevent a phone
from trying to re-register and recreating a session thread after
we had processed it.


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013524 [patch] Fixes skinny unload
====================================================================== 

---------------------------------------------------------------------- 
 (0095337) wedhorn (reporter) - 2008-11-23 01:35
 http://bugs.digium.com/view.php?id=10297#c95337 
---------------------------------------------------------------------- 
Sounds like the soft reset may be enough (might need some work on setting
the proper callstates on our part, but would be worth it).

The difference is that realtime (I assume) will only change one or two
variables rather than reloading the whole config that a reload does (well
that's what I wrote those stubs to do anyway). But yes, it will need some
work because some of the changes will basically result in having to create
a new structure, but if he just wants to set earlyrtp on for example, why
go through the hassle. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-23 01:35 wedhorn        Note Added: 0095337                          
======================================================================