[asterisk-bugs] [Asterisk 0010297]: [patch] Unload/load support for chan_skinny

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10297 
====================================================================== 
Reported By:                DEA
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10297
Category:                   Channels/chan_skinny/NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.0-beta8 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 76940 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2007-07-25 01:40 CDT
Last Modified:              2008-11-23 01:28 CST
====================================================================== 
Summary:                    [patch] Unload/load support for chan_skinny
Description: 
Reload is not working, but unload and load do work.
My reload code is ugly-simple, it calls the unload 
function, then the load function.  I would have thought
if I could manually unload and load that would be enough.


My threading knowledge is more than a bit weak, but the
existing code was 90% there already.  We needed to store
the address of the skinny_session thread launch from within
accept_thread so we could later cancel it.

Interestingly the skinnysession structure had a member to
store the thread address, but it did not appear to be used.

I also move the teardown of the accept thread to a point before
tearing down the sessions (and their threads) to prevent a phone
from trying to re-register and recreating a session thread after
we had processed it.


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013524 [patch] Fixes skinny unload
====================================================================== 

---------------------------------------------------------------------- 
 (0095336) DEA (reporter) - 2008-11-23 01:28
 http://bugs.digium.com/view.php?id=10297#c95336 
---------------------------------------------------------------------- 
At least on CCM, idle means no calls in any state.  I'll need to retest,
but I believe that we have most call states handled already and I would
not expect a call during a hold.

I am not opposed to trying to re-use and existing device/line structure,
but we will need to do more work to ensure we do not create duplicate
lines and speeddial associations.  I did try that initially, and found
it easier to just create new objects and prune the old, which reminds
me that I forgot to add line pruing to this patch.

I am interested in seeing how mvanbaak is handling the RealTime code.
I modelled the reload code on chan_sip, which also creates new objects
and prunes any that no longer exist in the config. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-23 01:28 DEA            Note Added: 0095336                          
======================================================================