[asterisk-bugs] [Asterisk 0012929]: retrydial hangs up when using a silent soundfile as anouncement

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12929 
====================================================================== 
Reported By:                snyfer
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   12929
Category:                   Applications/app_dial
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.0-beta9 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-06-26 03:22 CDT
Last Modified:              2008-11-19 19:50 CST
====================================================================== 
Summary:                    retrydial hangs up when using a silent soundfile as
anouncement
Description: 
    Hi 

tis is not a big problem and we do not need it at all. 
But I think this is a bug: 

When we call retrydial(silent,1,2,xxx,15,g)
and silent is a completely silent soundfile, retrydial hangs up after the
called partie hangs up. 

when we change the file to a "normal" soundfile it works fine. 

Maybe asterisk is checking or waiting for any bytes from the soundfile? 

Just to let you know. 

best regards 
Martin 

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0012930 retrydial hangs up when using a silent ...
====================================================================== 

---------------------------------------------------------------------- 
 (0095146) jpeeler (administrator) - 2008-11-19 19:50
 http://bugs.digium.com/view.php?id=12929#c95146 
---------------------------------------------------------------------- 
I'm attaching this patch mainly so that others can review the approach
taken. What I really wanted to do was just return that the file was empty
via return code in ast_filehelper, but ast_openstream_full returns NULL for
failure and the stream for success. The opening of the file stream is
successful since the file exists though. In this case, ast_playstream was
returning FSREAD_FAILURE because there was no data to return. I'm assuming
that creating a new field in ast_filestream just for the purposes of
flagging a zero length file is probably not justified. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-19 19:50 jpeeler        Note Added: 0095146                          
======================================================================