[asterisk-bugs] [Asterisk 0012180]: Comment on AST_MASQ_NOSTREAM in park_call_full misleading; announcement *can* go to parked channel.

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=12180 
====================================================================== 
Reported By:                davidw
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   12180
Category:                   Resources/res_features
Reproducibility:            N/A
Severity:                   text
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 106757 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             03-11-2008 08:43 CDT
Last Modified:              03-11-2008 10:01 CDT
====================================================================== 
Summary:                    Comment on AST_MASQ_NOSTREAM in park_call_full
misleading; announcement *can* go to parked channel.
Description: 
The comment in this code fragment from main/features.c in the trunk (and
res/res_features.c in 1.4) is not true, as simple invocation of the Park
application will result in the announcement going to the channel being
parked.  Furthermore, I cannot work out in what scenario it would be useful
to abort the announcement if the masquerade gets committed, so I'm not sure
what the comment is really trying to say.  (Masquerading isn't committed
for the parking sequence until after the announcement is made, and the only
interesting case I can think of is where the same channel is specified for
both chan and peer.)


  495   if (peer && ((pu->parkingnum != -1 &&
ast_strlen_zero(orig_chan_name)) || !strcasecmp(peer->name,
orig_chan_name))) { /* Only say number if it's a number and the channel
hasn't been masqueraded away */
  496     /* Make sure we don't start saying digits to the channel being
parked */
  497     ast_set_flag(peer, AST_FLAG_MASQ_NOSTREAM);
  498     ast_say_digits(peer, pu->parkingnum, "", peer->language);
  499     ast_clear_flag(peer, AST_FLAG_MASQ_NOSTREAM);
  500   }

====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 03-11-08 10:01  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 107465

U   trunk/main/features.c

------------------------------------------------------------------------
r107465 | file | 2008-03-11 10:01:20 -0500 (Tue, 11 Mar 2008) | 4 lines

Clarify comment about masquerading and playback of the parking slot.
(closes issue http://bugs.digium.com/view.php?id=12180)
Reported by: davidw

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=107465 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-11-08 10:01  svnbot         Checkin                                      
03-11-08 10:01  svnbot         Note Added: 0083717                          
03-11-08 10:01  svnbot         Status                   new => assigned     
03-11-08 10:01  svnbot         Assigned To               => file            
======================================================================