[asterisk-bugs] [Asterisk 0012180]: Comment on AST_MASQ_NOSTREAM in park_call_full misleading; announcement *can* go to parked channel.

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12180 
====================================================================== 
Reported By:                davidw
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12180
Category:                   Resources/res_features
Reproducibility:            N/A
Severity:                   text
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 106757 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             03-11-2008 08:43 CDT
Last Modified:              03-11-2008 09:59 CDT
====================================================================== 
Summary:                    Comment on AST_MASQ_NOSTREAM in park_call_full
misleading; announcement *can* go to parked channel.
Description: 
The comment in this code fragment from main/features.c in the trunk (and
res/res_features.c in 1.4) is not true, as simple invocation of the Park
application will result in the announcement going to the channel being
parked.  Furthermore, I cannot work out in what scenario it would be useful
to abort the announcement if the masquerade gets committed, so I'm not sure
what the comment is really trying to say.  (Masquerading isn't committed
for the parking sequence until after the announcement is made, and the only
interesting case I can think of is where the same channel is specified for
both chan and peer.)


  495   if (peer && ((pu->parkingnum != -1 &&
ast_strlen_zero(orig_chan_name)) || !strcasecmp(peer->name,
orig_chan_name))) { /* Only say number if it's a number and the channel
hasn't been masqueraded away */
  496     /* Make sure we don't start saying digits to the channel being
parked */
  497     ast_set_flag(peer, AST_FLAG_MASQ_NOSTREAM);
  498     ast_say_digits(peer, pu->parkingnum, "", peer->language);
  499     ast_clear_flag(peer, AST_FLAG_MASQ_NOSTREAM);
  500   }

====================================================================== 

---------------------------------------------------------------------- 
 file - 03-11-08 09:59  
---------------------------------------------------------------------- 
This was put in to solve the instance where attended transfers are being
used as blind transfers. So for instance:

A is talking to B
A wants to park, so they start an attended transfer to 700.
A begins hearing 7, but as they do they complete the attended transfer.
In the old code B would have continued hearing the digits (01 in my
example) but with the above code they will not hear it. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-11-08 09:59  file           Note Added: 0083716                          
======================================================================