[asterisk-bugs] [Asterisk 0012897]: [patch] IMAP forwarding does not go to the correct mailbox.

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12897 
====================================================================== 
Reported By:                jaroth
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   12897
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 122710 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             06-19-2008 09:22 CDT
Last Modified:              06-19-2008 13:13 CDT
====================================================================== 
Summary:                    [patch] IMAP forwarding does not go to the correct
mailbox.
Description: 
Forwarded messages are not stored in the correct IMAP mailbox.  The check
for the destination mailbox vm_state may fail (if that mailbox has never
been accessed) so an additional mailbox vm_state search (by user) is run to
ensure that a proper vm_state is available.
====================================================================== 

---------------------------------------------------------------------- 
 putnopvut - 06-19-08 13:13  
---------------------------------------------------------------------- 
Yes, it shouldn't be a problem to remove that one line from the patch.

The only problem I have with this patch is a minor one, and that is the
name of the function get_vm_state_by_user(). It's really a nitpick, but
there are similarly named functions (e.g. get_vm_state_by_imap_user and
get_vm_state_by_mailbox) which retrieve a vm_state from the vmstates list.
This new function actually allocates a new vm_state based on information
from the vm_user struct. As such, I would probably call it
create_vm_state_from_user or something similar. An interesting janitor
project would be to use that function for all dynamic allocation of
vm_state structures, but that's for a different time.

Anyway, coding-wise, this patch is fine. I'll get it merged with the
function name changed to something different. Thanks for the bug fix! 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-19-08 13:13  putnopvut      Note Added: 0088952                          
======================================================================