[asterisk-bugs] [Zaptel 0012406]: [patch] ztdynamic double buffering on rx, statistics, memleak

Sat Jun 7 14:00:31 CDT 2008

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12406 
====================================================================== 
Reported By:                biohumanoid
Assigned To:                
====================================================================== 
Project:                    Zaptel
Issue ID:                   12406
Category:                   ztdynamic
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Zaptel Version:             1.4.9.2 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             04-10-2008 06:05 CDT
Last Modified:              06-07-2008 14:00 CDT
====================================================================== 
Summary:                    [patch] ztdynamic double buffering on rx,
statistics, memleak
Description: 
In current implementation:
1. If we have more than one TDMoE device, we'll have a slip/skip. 2 TDMoE
devices can have phase jitter.
2. We have no statistics (which is necessary).
3. memleak
4. ztdynamic can't be a master for zaptel (but why not ?)
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 14:00  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 4220

_U  team/mattf/zaptel-1.4-stackcleanup/
U   team/mattf/zaptel-1.4-stackcleanup/Makefile
U   team/mattf/zaptel-1.4-stackcleanup/README
A   team/mattf/zaptel-1.4-stackcleanup/build_tools/zaptel_svn_tarball
U   team/mattf/zaptel-1.4-stackcleanup/kernel/pciradio.c
U   team/mattf/zaptel-1.4-stackcleanup/kernel/wctdm.c
U   team/mattf/zaptel-1.4-stackcleanup/kernel/xpp/.version
U   team/mattf/zaptel-1.4-stackcleanup/kernel/xpp/Kbuild
U  
team/mattf/zaptel-1.4-stackcleanup/kernel/xpp/utils/zconf/Zaptel/Config/Defaults.pm
U   team/mattf/zaptel-1.4-stackcleanup/kernel/zaptel-base.c
U   team/mattf/zaptel-1.4-stackcleanup/kernel/zaptel.h
U   team/mattf/zaptel-1.4-stackcleanup/kernel/ztdynamic.c
U   team/mattf/zaptel-1.4-stackcleanup/zaptel.init
U   team/mattf/zaptel-1.4-stackcleanup/ztcfg.c

------------------------------------------------------------------------
r4220 | mattf | 2008-06-07 14:00:30 -0500 (Sat, 07 Jun 2008) | 143 lines

Merged revisions
4165-4170,4173,4175-4176,4183-4185,4187,4190-4196,4213,4217 via svnmerge
from 
https://origsvn.digium.com/svn/zaptel/branches/1.4

........
r4165 | tzafrir | 2008-04-10 11:15:23 -0500 (Thu, 10 Apr 2008) | 5 lines

Officially bumping xpp version (xpp/.version) to 5566 .

Merged revisions 4164 via svnmerge from 
http://svn.digium.com/svn/zaptel/branches/1.2

........
r4166 | tzafrir | 2008-04-10 13:11:51 -0500 (Thu, 10 Apr 2008) | 2 lines

zaptel_svn_tarball - get a tarball fron an SVN snapshot.

........
r4167 | sruffell | 2008-04-10 16:01:59 -0500 (Thu, 10 Apr 2008) | 2 lines

Fixed typo in makefile which was preventing make from installing the udev
rules.

........
r4168 | dbailey | 2008-04-10 17:25:30 -0500 (Thu, 10 Apr 2008) | 3 lines

Correct problem where drivers implementing echocan_with_params was not
getting called
to disable the echo canceller

........
r4169 | mattf | 2008-04-11 16:16:47 -0500 (Fri, 11 Apr 2008) | 1 line

Make sure that we disable the echo canceller on the old style echocan()
function even if parameters are passed in.
........
r4170 | mattf | 2008-04-11 16:17:55 -0500 (Fri, 11 Apr 2008) | 1 line

Take out part of a commit to the wct4xxp driver that wasn't supposed to go
in
........
r4173 | kpfleming | 2008-04-17 07:20:26 -0500 (Thu, 17 Apr 2008) | 6 lines

when processing ZT_SET_DIALPARAMS, don't return an error for out-of-range
tone durations, just ignore them (so that applications that don't
initialize the entire zt_dialparams structure won't fail to set the ones
they do initialize)

(closes issue http://bugs.digium.com/view.php?id=12456)
Reported by: fnordian
Tested by: fnordian

........
r4175 | tzafrir | 2008-04-17 09:27:50 -0500 (Thu, 17 Apr 2008) | 5 lines

Avoid a double-free in ztdynamic.c ztdynamic_chanfree.diff from bug
http://bugs.digium.com/view.php?id=12406
.

Merged revisions 4174 via svnmerge from 
http://svn.digium.com/svn/zaptel/branches/1.2

........
r4176 | jdixon | 2008-04-18 10:19:00 -0500 (Fri, 18 Apr 2008) | 2 lines

Fixed monitoring of zap pseudo channels

........
r4183 | mattf | 2008-04-19 16:54:03 -0500 (Sat, 19 Apr 2008) | 1 line

Partial fix for http://bugs.digium.com/view.php?id=9379.  Fixes potential race
condition in open and close
routines for zaptel devices
........
r4184 | mattf | 2008-04-19 16:56:06 -0500 (Sat, 19 Apr 2008) | 1 line

Remove unintentional svn property addition
........
r4185 | mattf | 2008-04-19 17:05:42 -0500 (Sat, 19 Apr 2008) | 1 line

Fix compiler from complaining
........
r4187 | tzafrir | 2008-04-21 16:27:59 -0500 (Mon, 21 Apr 2008) | 4 lines

Zaptel::Config::Default - don't die if no config file.

(Accidentally left out of the merge from 1.2)

........
r4190 | jdixon | 2008-04-22 17:07:08 -0500 (Tue, 22 Apr 2008) | 2 lines

Fixed problem preventing multiple channels from using multiple CTCSS

........
r4191 | jdixon | 2008-04-22 23:36:22 -0500 (Tue, 22 Apr 2008) | 2 lines

Updated to latest code, fixed bug in serial i/o

........
r4192 | tzafrir | 2008-04-23 04:48:56 -0500 (Wed, 23 Apr 2008) | 2 lines

Bumped into yet another incompatibility.

........
r4193 | tzafrir | 2008-04-23 14:20:53 -0500 (Wed, 23 Apr 2008) | 10 lines

A test for a specific #define in zconfig.h was done by invoking cpp .
Sadly the change of CFLAGS handling in kernel 2.6.24 meant that it is no
longer as easy to invoke cpp on our own. 

Impact: On kernel >= 2.6.24, xpd_bri never got built, even if the
bri_dchan patch was applied.

Fix: use a simpler grep instead. Hopefully noone passes it through other
means. This should hopfully fix issue http://bugs.digium.com/view.php?id=12426 .

........
r4194 | sruffell | 2008-04-24 13:17:12 -0500 (Thu, 24 Apr 2008) | 5 lines

Fixes a regression in versions 1.2.25 and 1.4.19 identified by korihor
where
the wctdm driver was no longer properly recognizing polarity reversals.

(closes issue http://bugs.digium.com/view.php?id=12419)

........
r4195 | qwell | 2008-04-25 13:10:06 -0500 (Fri, 25 Apr 2008) | 1 line

Based on a comment made by moy in #asterisk-dev, and the surrounding code
in these functions, I believe that this is what was actually intended in
r4130.
........
r4196 | qwell | 2008-04-25 15:47:07 -0500 (Fri, 25 Apr 2008) | 7 lines

Since MF R2 tones are generated continuously, we need to not set the
dialing status.

(closes issue http://bugs.digium.com/view.php?id=12526)
Reported by: moy
Patches:
      zaptel-mf-dialing-rev4195.patch uploaded by moy (license 222)

........
r4213 | twilson | 2008-05-01 11:46:44 -0500 (Thu, 01 May 2008) | 2 lines

Allow $(ARCH) to be overridden and pass on through $(KMAKE)

........
r4217 | qwell | 2008-05-01 14:37:07 -0500 (Thu, 01 May 2008) | 7 lines

Clarify a message.  Some hardware doesn't provide timing, so this could be
confusing.

(closes issue http://bugs.digium.com/view.php?id=12459)
Reported by: panderson
Patches:
      zaptel.init.patch uploaded by panderson (license 469)

........

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=4220 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 14:00  svnbot         Note Added: 0088422                          
======================================================================