[asterisk-bugs] [Asterisk 0007708]: [patch] properly using LDLIBS

noreply at bugs.digium.com noreply at bugs.digium.com
Sat Jun 7 11:44:45 CDT 2008 

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=7708 
====================================================================== 
Reported By:                Mithraen
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   7708
Category:                   Core/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           I did not set the version :( 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 1274 
Disclaimer on File?:        Yes 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             08-10-2006 18:06 CDT
Last Modified:              06-07-2008 11:44 CDT
====================================================================== 
Summary:                    [patch] properly using LDLIBS
Description: 
zaptel Makefile use LDFLAGS where LDLIBS must be used, and incorretly links
with libm, that affects systems with -Wl,--as-needed by default
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 11:44  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 1323

_U  team/group/vldtmf/
U   team/group/vldtmf/Makefile
U   team/group/vldtmf/acinclude.m4
U   team/group/vldtmf/configure
U   team/group/vldtmf/configure.ac
U   team/group/vldtmf/fxotune.c
U   team/group/vldtmf/wct4xxp_base.c
U   team/group/vldtmf/xpp/Makefile
U   team/group/vldtmf/xpp/card_fxo.c
U   team/group/vldtmf/xpp/card_fxs.c
U   team/group/vldtmf/xpp/utils/genzaptelconf
U   team/group/vldtmf/xpp/utils/xpp_fxloader
U   team/group/vldtmf/xpp/xbus-core.c
U   team/group/vldtmf/xpp/xpp_usb.c
U   team/group/vldtmf/xpp/xpp_zap.c
U   team/group/vldtmf/zaptel.c
U   team/group/vldtmf/zaptel.h
U   team/group/vldtmf/zaptel.init
U   team/group/vldtmf/zconfig.h

------------------------------------------------------------------------
r1323 | russell | 2008-06-07 11:44:43 -0500 (Sat, 07 Jun 2008) | 261 lines

Merged revisions
1277-1294,1296-1297,1299,1301-1303,1305,1307,1310,1312,1314,1316,1318-1320
via svnmerge from 
https://origsvn.digium.com/svn/zaptel/trunk

................
r1277 | north | 2006-08-09 22:04:13 -0400 (Wed, 09 Aug 2006) | 4 lines

Fixed a typo.

Makes one wonder how long this has been like that..

................
r1278 | tzafrir | 2006-08-09 22:15:20 -0400 (Wed, 09 Aug 2006) | 1 line

fixed a typo: it's waitfor_xpds and not wait_for_xpds
................
r1279 | tzafrir | 2006-08-09 22:38:43 -0400 (Wed, 09 Aug 2006) | 4 lines

- In SIG_CHANGED only sig_toggles bits are interesting (was good in FXS,
  now fixed in FXO).
- Better DBG messages for SIG_CHANGED (FXS and FXO).
- Start work on new RING logic (for FXO caller id).
................
r1280 | tzafrir | 2006-08-09 22:40:45 -0400 (Wed, 09 Aug 2006) | 4 lines

Better LED handling for fxo (copied from fxs):
  - Fix both branches/RELEASE-1.1.0 and trunk/
  - Use a ledcontrol bitmask to mark led on/off
  - Actuall led commands are send only from handle_fxo_leds()
................
r1281 | tzafrir | 2006-08-09 22:42:03 -0400 (Wed, 09 Aug 2006) | 3 lines

* xpp_fxloader: Allow loading just USB firmware with command 'usb'
* xpp_fxloader: also add 'load' as an alias of 'xppdetect'
* xpp_fxloader: and add a 'help' message.
................
r1282 | tzafrir | 2006-08-09 22:48:07 -0400 (Wed, 09 Aug 2006) | 2 lines

Bugfix: the PROC_USBXPP_SUMMARY does not own xpp->proc_xbus_dir and should
        not nullify it (partial reversal of changeset:1225)
................
r1283 | tzafrir | 2006-08-09 22:53:20 -0400 (Wed, 09 Aug 2006) | 1 line

genzaptelconf: fixed typo that prevented getting caller ID on zaptel
trunks
................
r1284 | tzafrir | 2006-08-09 22:55:25 -0400 (Wed, 09 Aug 2006) | 1 line

xbus-core.c: documentation updates.
................
r1285 | tzafrir | 2006-08-09 23:12:25 -0400 (Wed, 09 Aug 2006) | 8 lines

* New SOFT_RING detection in FXO:
  - Poll register 0x05 on each DAA
  - When enough energy (value of 0x20|0x40 occurs enough times), raise
    the ringing[] flag.
  - When the value show no energy, lower the ringing[] flag.
  - When we get SIG_CHANGED of stop ringing -- stop polling.

* More debugging messages for proc files
................
r1286 | tzafrir | 2006-08-09 23:16:36 -0400 (Wed, 09 Aug 2006) | 1 line

Bugfix: should not call zaptel for unregistered XPD's.
................
r1287 | tzafrir | 2006-08-09 23:19:07 -0400 (Wed, 09 Aug 2006) | 1 line

Improve checking order in xpp_zap.c
................
r1288 | tzafrir | 2006-08-09 23:21:47 -0400 (Wed, 09 Aug 2006) | 1 line

card_fxo.c: Fix a potential bug: battery voltage is a 2's complement
value.
................
r1289 | tzafrir | 2006-08-09 23:26:12 -0400 (Wed, 09 Aug 2006) | 6 lines

Solves spinlock-panic in CentOS 4.

zt_transmit() was called in spinlock protected context. However, it may
call back our hook setting code which tries to lock the same spinlock.

As a safeguard, the same logic was applied to zt_receive().
................
r1290 | tzafrir | 2006-08-09 23:33:57 -0400 (Wed, 09 Aug 2006) | 3 lines

* Added support for readingconfiguration from /etc/sysconfig/zaptel .
* Config file location can be overriden by environment.
* Removed an obsolete function.
................
r1291 | tzafrir | 2006-08-09 23:40:10 -0400 (Wed, 09 Aug 2006) | 3 lines

Fix ring detection logic in FXO:
Detect ring stop only when register 0x05 shows no ring voltage for
enough samples. This is done via noring_thresh[].
................
r1292 | tzafrir | 2006-08-09 23:47:30 -0400 (Wed, 09 Aug 2006) | 1 line

Show SOFT_RING compile status when xpd_fxo module is loaded.
................
r1293 | tzafrir | 2006-08-09 23:56:43 -0400 (Wed, 09 Aug 2006) | 6 lines

* A delay loop waiting for a slow udev to generate /dev/zap/ctl
* Work around stupid call to ztcfg on modprobe (as inserted by zaptel 
  install script)
* -M now edits /etc/sysconfig/zaptel if it find that file and not
/etc/modules
* editing of /etc/sysconfig/zaptel: remove all lines that begin with 
  MODULES=, and add MODULES="list of modules" to the end.
................
r1294 | tzafrir | 2006-08-12 11:03:08 -0400 (Sat, 12 Aug 2006) | 3 lines

* Wait for /dev/zap/ctl to appear if udev takes its time creating it.
* Try looking for ztcfg in /usr/sbin as well.
* Also allow setting the location of ztcfg from environment.
................
r1296 | russell | 2006-08-13 19:19:52 -0400 (Sun, 13 Aug 2006) | 2 lines

use LDLIBS instead of LDFLAGS in various places (issue
http://bugs.digium.com/view.php?id=7708, Mithraen)

................
r1297 | russell | 2006-08-13 19:46:10 -0400 (Sun, 13 Aug 2006) | 2 lines

use AC_MSG_* instead of echo to support ./configure --silent (issue
http://bugs.digium.com/view.php?id=7722)

................
r1299 | russell | 2006-08-13 20:56:04 -0400 (Sun, 13 Aug 2006) | 11 lines

Merged revisions 1298 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
r1298 | russell | 2006-08-13 20:54:28 -0400 (Sun, 13 Aug 2006) | 3 lines

the change from $(PWD) to $(SUBDIRS) breaks the build on some systems. So,
just
use them both ... (issue http://bugs.digium.com/view.php?id=7720)

........

................
r1301 | russell | 2006-08-13 21:45:55 -0400 (Sun, 13 Aug 2006) | 10 lines

Merged revisions 1300 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
r1300 | russell | 2006-08-13 21:44:59 -0400 (Sun, 13 Aug 2006) | 2 lines

add a note that ENABLE_TASKLETS is not implemented in wct4xxp (issue
http://bugs.digium.com/view.php?id=7688)

........

................
r1302 | russell | 2006-08-13 21:55:06 -0400 (Sun, 13 Aug 2006) | 3 lines

don't try to include menuselect.makeopts or makeopts if the target is
clean,
distclean, or update (fixes issue http://bugs.digium.com/view.php?id=7723)

................
r1303 | russell | 2006-08-13 22:48:33 -0400 (Sun, 13 Aug 2006) | 4 lines

add a SHORT_FLASH_TIME option to zconfig.h for european phones with short
flash
times that sometimes get misinterpreted as a pulse digit 1 
(issue http://bugs.digium.com/view.php?id=7365, gagravarr)

................
r1305 | russell | 2006-08-14 00:07:49 -0400 (Mon, 14 Aug 2006) | 11 lines

Merged revisions 1304 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
r1304 | russell | 2006-08-14 00:07:00 -0400 (Mon, 14 Aug 2006) | 3 lines

fix potential deadlock found by kernel's lock checker 
(issue http://bugs.digium.com/view.php?id=7620, reported by smurfix, fixed by
Corydon)

........

................
r1307 | kpfleming | 2006-08-14 16:42:35 -0400 (Mon, 14 Aug 2006) | 10
lines

Merged revisions 1306 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
r1306 | kpfleming | 2006-08-14 15:40:55 -0500 (Mon, 14 Aug 2006) | 2 lines

revert this change until a version that compiles on 2.4 kernels and older
2.6 kernels is made available and tested

........

................
r1310 | mattf | 2006-08-15 14:42:22 -0400 (Tue, 15 Aug 2006) | 2 lines

Add support for looping back a single channel

................
r1312 | russell | 2006-08-15 17:34:16 -0400 (Tue, 15 Aug 2006) | 11 lines

Merged revisions 1311 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
r1311 | russell | 2006-08-15 17:30:49 -0400 (Tue, 15 Aug 2006) | 3 lines

fix passing a 'w' to wait when using pulse dialing 
(issue http://bugs.digium.com/view.php?id=7738, hanabana)

........

................
r1314 | russell | 2006-08-15 17:44:46 -0400 (Tue, 15 Aug 2006) | 12 lines

Merged revisions 1313 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
r1313 | russell | 2006-08-15 17:43:26 -0400 (Tue, 15 Aug 2006) | 4 lines

fix erroneous check to see if PWD was set before setting it in the Zaptel
Makefile.  It should always be set.  If not, it breaks the build when
using
recursive calls to make. (issue http://bugs.digium.com/view.php?id=7733,
tzafrir)

........

................
r1316 | russell | 2006-08-15 18:14:21 -0400 (Tue, 15 Aug 2006) | 12 lines

Merged revisions 1315 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
r1315 | russell | 2006-08-15 18:06:13 -0400 (Tue, 15 Aug 2006) | 4 lines

Ensure that fopen() is only called once for the debug output file to
prevent
excessive file descriptor leakage when this function is called many times
in
a loop.  (issue http://bugs.digium.com/view.php?id=7203)

........

................
r1318 | tilghman | 2006-08-15 21:40:16 -0400 (Tue, 15 Aug 2006) | 10 lines

Merged revisions 1317 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
r1317 | tilghman | 2006-08-15 20:36:34 -0500 (Tue, 15 Aug 2006) | 2 lines

Bug 7624 - Debian lacks /var/lock/subsys

........

................
r1319 | kpfleming | 2006-08-16 16:01:27 -0400 (Wed, 16 Aug 2006) | 2 lines

clean up libtonezone-related rules

................
r1320 | kpfleming | 2006-08-16 17:09:21 -0400 (Wed, 16 Aug 2006) | 2 lines

run ranlib on static library

................

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=1323 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 11:44  svnbot         Note Added: 0088152                          
======================================================================

More information about the asterisk-bugs mailing list