[asterisk-bugs] [Zaptel 0007203]: [patch] fxotune doesn't close files when in debug mode

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=7203 
====================================================================== 
Reported By:                tzafrir
Assigned To:                russell
====================================================================== 
Project:                    Zaptel
Issue ID:                   7203
Category:                   Utilities
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Zaptel Version:             SVN 
SVN Branch (only for SVN checkouts, not tarball releases): trunk 
SVN Revision (number only!): 1077 
Disclaimer on File?:        Yes 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             05-22-2006 09:24 CDT
Last Modified:              06-07-2008 11:44 CDT
====================================================================== 
Summary:                    [patch] fxotune doesn't close files when in debug
mode
Description: 
fopen without fclose may work, if it's not in a loop.

The attached patch does not remove all the possible leakage sources. It
just makes the contents of the debug file partially useful (of the last
useful channel)
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 11:44  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 1316

_U  trunk/
U   trunk/fxotune.c

------------------------------------------------------------------------
r1316 | russell | 2008-06-07 11:44:35 -0500 (Sat, 07 Jun 2008) | 12 lines

Merged revisions 1315 via svnmerge from 
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
r1315 | russell | 2006-08-15 18:06:13 -0400 (Tue, 15 Aug 2006) | 4 lines

Ensure that fopen() is only called once for the debug output file to
prevent
excessive file descriptor leakage when this function is called many times
in
a loop.  (issue http://bugs.digium.com/view.php?id=7203)

........

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=1316 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 11:44  svnbot         Checkin                                      
06-07-08 11:44  svnbot         Note Added: 0088151                          
======================================================================