[asterisk-bugs] [Asterisk 0003186]: [patch] zconfig.h kernel version check incorrect for 2.4.20

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=3186 
====================================================================== 
Reported By:                drmac
Assigned To:                malcolmd
====================================================================== 
Project:                    Asterisk
Issue ID:                   3186
Category:                   Core/General
Reproducibility:            N/A
Severity:                   tweak
Priority:                   normal
Status:                     closed
Asterisk Version:           I did not set the version :( 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             12-29-2004 08:49 CST
Last Modified:              06-07-2008 10:46 CDT
====================================================================== 
Summary:                    [patch] zconfig.h kernel version check incorrect for
2.4.20
Description: 
Hey gang,
 I've got 2.4.20-8 kernel here and tried to compile zaptel for HDLC last
night. I kept getting the following error:

[root at asterisk zaptel]# make
cc -I. -O4 -g -Wall -DBUILDING_TONEZONE    -DSTANDALONE_ZAPATA
-DZAPTEL_CONFIG=\"/etc/zaptel.conf\"   -c -o gendigits.o gendigits.c
cc -o gendigits gendigits.o -lm
./gendigits
gcc -I/usr/src/linux-2.4/include -O6 -DMODULE -D__KERNEL__ -DEXPORT_SYMTAB
-I/usr/src/linux/drivers/net -Wall -I. -Wstrict-prototypes
-fomit-frame-pointer -I/usr/src/linux/drivers/net/wan -I
/usr/src/linux/include -I/usr/src/linux/include/net -DMODVERSIONS -include
/usr/src/linux-2.4/include/linux/modversions.h  -DSTANDALONE_ZAPATA -c
zaptel.c
zaptel.c: In function `zt_ctl_ioctl':
zaptel.c:3164: warning: assignment from incompatible pointer type
zaptel.c:3166: warning: assignment from incompatible pointer type
zaptel.c:3174: structure has no member named `close'
zaptel.c:3175: structure has no member named `set_mode'
zaptel.c:3176: warning: assignment from incompatible pointer type
zaptel.c: In function `__zt_putbuf_chunk':
zaptel.c:5757: warning: implicit declaration of function `hdlc_netif_rx'
make: *** [zaptel.o] Error 1

After reading thru the code, I found out that if I changed line 63 in
zaptel.c from #ifndef to #ifdef then everything compiled and worked.

I switched the #ifdef back to original, then I found the kernel check in
zconfig.h and changed it to (2,4,19) and everything compiled fine and
worked. 

So I'm guessing that kernels 2.4.20 and higher need the new methods.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 10:46  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 523

U   trunk/zconfig.h

------------------------------------------------------------------------
r523 | malcolmd | 2008-06-07 10:46:56 -0500 (Sat, 07 Jun 2008) | 2 lines

Small change per bug http://bugs.digium.com/view.php?id=3186

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=523 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 10:46  svnbot         Checkin                                      
06-07-08 10:46  svnbot         Note Added: 0087982                          
======================================================================