[asterisk-bugs] [Asterisk 0001089]: Return before spin_unlock - found in code review

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=1089 
====================================================================== 
Reported By:                woofie
Assigned To:                jamesgolovich
====================================================================== 
Project:                    Asterisk
Issue ID:                   1089
Category:                   Core/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           I did not set the version :( 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             02-23-2004 21:34 CST
Last Modified:              06-07-2008 10:36 CDT
====================================================================== 
Summary:                    Return before spin_unlock - found in code review
Description: 
Code review of zaptel.c found, CVS version - last night

line 3206 :  return -EBUSY;

however, code is in a spin_lock_irqsave(&chan->lock, flags) call. 


====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 10:36  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 320

U   trunk/zaptel.c

------------------------------------------------------------------------
r320 | citats | 2008-06-07 10:36:07 -0500 (Sat, 07 Jun 2008) | 2 lines

Return before spin_unlock (bug http://bugs.digium.com/view.php?id=1089)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=320 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 10:36  svnbot         Checkin                                      
06-07-08 10:36  svnbot         Note Added: 0087936                          
======================================================================