[asterisk-bugs] [Asterisk 0013133]: [patch] Some fixes to autocompletion in some commands.
noreply at bugs.digium.com
noreply at bugs.digium.com
Tue Jul 22 17:34:35 CDT 2008
The following issue has been SUBMITTED.
======================================================================
http://bugs.digium.com/view.php?id=13133
======================================================================
Reported By: eliel
Assigned To:
======================================================================
Project: Asterisk
Issue ID: 13133
Category: General
Reproducibility: always
Severity: minor
Priority: normal
Status: new
Asterisk Version: SVN
SVN Branch (only for SVN checkouts, not tarball releases): trunk
SVN Revision (number only!): 132644
Disclaimer on File?: N/A
Request Review:
======================================================================
Date Submitted: 07-22-2008 17:34 CDT
Last Modified: 07-22-2008 17:34 CDT
======================================================================
Summary: [patch] Some fixes to autocompletion in some
commands.
Description:
Changes applied by this patch:
- Fix autocompletion in 'sip prune realtime', sip peers where never auto
completed. Now we complete this command with:
'sip prune realtime peer' -> all | like | sip peers
Also I have modified the syntax in the usage, was wrong...
- Pass ast_cli_args->argv and ast_cli_args->argc while running
autocompletion on CLI commands (CLI_GENERATE).
With this we avoid comparisons on ast_cli_args->line like this:
strcasestr(a->line, " description")
strcasestr(a->line, "descriptions ")
strcasestr(a->line, "realtime peer"), and so on..
Making the code more confusing (check the spaces in description!).
The only thing we must be sure is to first check a->pos or a->argc.
- Fix 'iax2 prune realtime' autocompletion, now we autocomplete this
command with 'all' & 'iax2 peers', check a look that iax2 peers where all
the peers, now only the ones in the cache.. (For this I have changed
function complete_iax2_peers to support flags, like complete_sip_peers).
======================================================================
Issue History
Date Modified Username Field Change
======================================================================
07-22-08 17:34 eliel Asterisk Version => SVN
07-22-08 17:34 eliel SVN Branch (only for SVN checkou => trunk
07-22-08 17:34 eliel SVN Revision (number only!) => 132644
07-22-08 17:34 eliel Disclaimer on File? => N/A
======================================================================
More information about the asterisk-bugs
mailing list