[asterisk-bugs] [Zaptel 0008290]: [patch] zap hookstate is never set offhook if wctdm module is loaded with an active fxo line

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=8290 
====================================================================== 
Reported By:                tmarkov
Assigned To:                kpfleming
====================================================================== 
Project:                    Zaptel
Issue ID:                   8290
Category:                   wctdm
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Zaptel Version:              1.2.10 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             11-03-2006 17:28 CST
Last Modified:              01-16-2008 08:02 CST
====================================================================== 
Summary:                    [patch] zap hookstate is never set offhook if wctdm
module is loaded with an active fxo line
Description: 
If #define ZAP_CHECK_HOOKSTATE is uncommented in chan_zap.c, then the
hookstate stays onhook if the wctdm module is loaded with an active line. 
Removing line and reinserting will cause the hookstate to initialize
properly.  The problem appears to be that wc->mod[card].fxo.battery never
gets initialized to 0, so in wctdm_voicedaa_check_hook() the test "if
(!wc->mod[card].fxo.battery && !wc->mod[card].fxo.battdebounce)" is never
entered, and the hookstate remains onhook upon module startup.  Only a
cycling of line voltage will correct the problem.  I have attached a patch
which initializes the battery variable and fixes the problem for me.
====================================================================== 

---------------------------------------------------------------------- 
 flefoll - 01-16-08 08:02  
---------------------------------------------------------------------- 
As far as my uploads are concerned, I agree with menault and you can delete
all uploads, except last two ones. One possible restriction, as menault
said, is keeping the logs, perhaps, since they help understanding what the
problem is.

I understand that chan_zap.c patch will never be applied to branch 1.4,
but it may help someone else using this branch. Curious to see new
chan_zap.c in SVN trunk, but SVN still is under re-construction at the
moment.

If menault's fix depends on Asterisk SVN trunk, then mine may be kept as
an alternative for those who use Branch 1.4 (fix: initial fxo state, with
or without additional feature: channel alarms in chan_zap). Anyway, I'll be
glad to see a fix integrated in Zaptel/Asterisk code, whatever fix ! 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-16-08 08:02  flefoll        Note Added: 0080757                          
======================================================================