[asterisk-bugs] [Zaptel 0008290]: [patch] zap hookstate is never set offhook if wctdm module is loaded with an active fxo line

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=8290 
====================================================================== 
Reported By:                tmarkov
Assigned To:                kpfleming
====================================================================== 
Project:                    Zaptel
Issue ID:                   8290
Category:                   wctdm
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Zaptel Version:              1.2.10 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             11-03-2006 17:28 CST
Last Modified:              01-16-2008 07:49 CST
====================================================================== 
Summary:                    [patch] zap hookstate is never set offhook if wctdm
module is loaded with an active fxo line
Description: 
If #define ZAP_CHECK_HOOKSTATE is uncommented in chan_zap.c, then the
hookstate stays onhook if the wctdm module is loaded with an active line. 
Removing line and reinserting will cause the hookstate to initialize
properly.  The problem appears to be that wc->mod[card].fxo.battery never
gets initialized to 0, so in wctdm_voicedaa_check_hook() the test "if
(!wc->mod[card].fxo.battery && !wc->mod[card].fxo.battdebounce)" is never
entered, and the hookstate remains onhook upon module startup.  Only a
cycling of line voltage will correct the problem.  I have attached a patch
which initializes the battery variable and fixes the problem for me.
====================================================================== 

---------------------------------------------------------------------- 
 meneault - 01-16-08 07:49  
---------------------------------------------------------------------- 
I just uploaded 8290-alarm-total_1_4_rev3696 which contains all the
necessary changes for the bug to be fixed (wctdm.c, wctdm24xxp/base.c and
zaptel-base.c).
This time I only uploaded one file.

Notes:
- I didn't test it (only compiled it).
  => this week-end I'll test it if asterisk svn server is up because I
don't have the latest revision from trunk needed to test the bug
resolution.

- the change to zaptel-base.c is optional (only safer if you apply it).


flefoll:
 - you should only apply 8290-alarm-total_1_4_rev3696 my older patches are
not needed. But as a requirement you must use it with latest asterisk
revision from TRUNK (otherwise it won't work). 

- the rxhooksig issue is not important anymore from now to solve the bug
issue.
rxhooksig won't be used anymore in chan_zap to check for line availability
(FXO case) only the alarm state will be checked. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-16-08 07:49  meneault       Note Added: 0080756                          
======================================================================