[asterisk-bugs] [Asterisk 0013140]: [patch] Setting up a HANGUPCAUSETEXT variable for SIP channel

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13140 
====================================================================== 
Reported By:                cpina
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13140
Category:                   Channels/chan_sip/NewFeature
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 133097 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-07-23 13:31 CDT
Last Modified:              2008-08-11 15:23 CDT
====================================================================== 
Summary:                    [patch] Setting up a HANGUPCAUSETEXT variable for
SIP channel
Description: 
I found that sometimes it's needed to have the exactly "SIP disconnect
code" from the other end. HANGUPCAUSE could not be enough as it's mapping
different SIP codes to the same number.

After talking about it in -dev mailing list:
http://lists.digium.com/pipermail/asterisk-dev/2008-July/034004.html

Some people was interested and attached there is a initial patch to
implement it.

Note: there is a problem with a Dial to multiple channels: same problem
than HANGUPCAUSE. A good solution, as talked here:

http://lists.digium.com/pipermail/asterisk-dev/2008-July/034020.html

is to have a hash/function handling all disconnect reasons. In this status
the classic HANGUPCAUSE and also HANGUPCAUSETEXT don't handle it.

PATCH:
Mail:
http://lists.digium.com/pipermail/asterisk-dev/2008-July/034049.html
Attachment:
http://lists.digium.com/pipermail/asterisk-dev/attachments/20080723/6da29aa3/attachment.patch

In my tests the patch has been working fine. If you see any problem or
patch should be done in a different way, I'm open to work on it.
====================================================================== 

---------------------------------------------------------------------- 
 (0091322) cpina (reporter) - 2008-08-11 15:23
 http://bugs.digium.com/view.php?id=13140#c91322 
---------------------------------------------------------------------- 
I've uploaded a new patch. This one adds a comment in one of the places.

In my opinion, other places are easy to understand and would be
over-commenting (following what I have seen in Asterisk code). I can also
add if more comments are needed. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-11 15:23 cpina          Note Added: 0091322                          
======================================================================