[asterisk-bugs] [Asterisk 0013223]: [patch] Generate a version when asterisk is built in a git repository

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13223 
====================================================================== 
Reported By:                tzafrir
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13223
Category:                   Core/BuildSystem
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 133488 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-08-02 11:09 CDT
Last Modified:              2008-08-05 10:02 CDT
====================================================================== 
Summary:                    [patch] Generate a version when asterisk is built in
a git repository
Description: 
Currently asterisk knows to generate version.h from two potential sources:

1. a .version file in the source tree. This is used for tarballs or
tarballs.
2. 'svn info' when building an a subversion repository and there's no
.version file.

This patch adds handling to building in a git repository, similar to (2):

* Like in (2), the numeric version number is 999999.
* Unlike in (2), though, I could not think of a nice way to derive a text
version string. Thus the version name is simply "GIT".

Without the Makefile part of this patch, building fails in a git
repository (specifically: at res/res_snmp.c). Thus I do not consider it a
feature.

The current patch is vs. 1.4. A similar patch should probably work vs.
1.6. I'll add one soon.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013132 [patch] dummy-select - a simplified men...
====================================================================== 

---------------------------------------------------------------------- 
 (0091095) tzafrir (manager) - 2008-08-05 10:02
 http://bugs.digium.com/view.php?id=13223#c91095 
---------------------------------------------------------------------- 
Right. That patch does use any information from the git repository.

As I mentioned in the later comment, the Makefile part should be
simplified into "everything except a .version file", as there's nothing
special there for the case of a subversion repository.

So we're left with the need to generate a version string. Maybe just
change it to "if there's no .version and we're not in a subversion
repository, just make label it "UNKNOWN"? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-05 10:02 tzafrir        Note Added: 0091095                          
======================================================================