[asterisk-bugs] [Asterisk 0011310]: Impliment CallForwardAll

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11310 
====================================================================== 
Reported By:                DEA
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   11310
Category:                   Channels/chan_skinny
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 89312 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             11-19-2007 16:34 CST
Last Modified:              11-20-2007 10:18 CST
====================================================================== 
Summary:                    Impliment CallForwardAll
Description: 
The comment in chan_skinny saying that DND == CFwdAll has bothered
me for awhile now.

DND is supposed to simply mute the phones ringer and is a basic toggle.

CFwdAll should allow the user to enter a phone number to forward calls
to if not already set, or clear the current forwarding if it is set.


====================================================================== 

---------------------------------------------------------------------- 
 qwell - 11-20-07 10:18  
---------------------------------------------------------------------- 
Ahh, I did add it.  Excellent.

You missed one very important detail while looking at those localization
messages...they are in octal, not hex. :)

I believe 0x3F would be correct for SOFTKEY_DND.  Take a look at the
definition of soft_key_template_default[] (you'll need to add DND there as
well).  You can see there how there SOFTKEY_* definitions match up with the
localization messages (hex vs octal).  \077 = 0x3F

Note that this is only true for the SOFTKEY definition, and not for the
STIMULUS - I do not know what that one should be - if one even exists for
it.

Besides - the softkeys mappings are pretty much arbitrary, since we handle
it all at the server anyways.  The phone doesn't care what it sends, nor
what it is labeled. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-20-07 10:18  qwell          Note Added: 0074086                          
======================================================================