[asterisk-bugs] [Asterisk 0011152]: Over quota errors ignored

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11152 
====================================================================== 
Reported By:                selsky
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   11152
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             11-02-2007 13:59 CDT
Last Modified:              11-13-2007 16:07 CST
====================================================================== 
Summary:                    Over quota errors ignored
Description: 
My IMAP server says that my voicemail folder is over quota when Asterisk
tries to append the new message, but the quota error is ignored and the
caller is not told that the voicemail was not saved in the mailbox.

Asterisk logs:

[Nov  2 14:46:24] ERROR[25200] app_voicemail.c: IMAP Error: Over quota
[Nov  2 14:46:24] ERROR[25200] app_voicemail.c: Error while sending the
message to
{imaphost:993/imap/authuser=asterisk/notls/ssl/user=selsky}voicemail

Cyrus telemetry logs:

>1194028385>0000000d NO Over quota
>1194028969>0000001c NO Over quota

Asterisk is trying to append the message to the folder twice, but it fails
both times.  This failure is never reported back to the caller with an
over-quota message.
====================================================================== 

---------------------------------------------------------------------- 
 putnopvut - 11-13-07 16:07  
---------------------------------------------------------------------- 
There are a few reasons for not using the server response from the append:

1. We're using the imap c-client library for interfacing with IMAP servers
and their function for appending mail only has two possible return values
(T for success or NIL for failure). In other words, it is not possible to
interpret why an append failed.

2. In most cases, there isn't a way to alert the caller after the append
(because they hung up). In cases where the caller is still on the line,
they may have to wait an unacceptably long amount of time to hear the
server response if there is any latency between the Asterisk server and the
IMAP server.

3. Alerting the caller that the mailbox is full before they leave a
recording is the same behavior as non-IMAP methods of storage, plus it also
saves the caller from possibly recording a long message if they hear
beforehand that the mailbox is full.


Apparently the patch I provided is not doing the job, so I will rework it
and post the update later. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-13-07 16:07  putnopvut      Note Added: 0073604                          
======================================================================