[asterisk-bugs] [Asterisk 0010690]: sip peer with missing close bracket causes all subsequent sip peers not to load

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10690 
====================================================================== 
Reported By:                dtyoo
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10690
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:            1.4.9  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             09-10-2007 17:34 CDT
Last Modified:              11-13-2007 15:41 CST
====================================================================== 
Summary:                    sip peer with missing close bracket causes all
subsequent sip peers not to load
Description: 
We have found that if you leave the trailing square bracket off a given sip
peer name in sip.conf, then you reload chan_sip.so, all peers that would be
loaded after the broken peer do not load.  It looks like the config parser
understands what is wrong as I see the following in the messages file:

config.c: parse error: no closing ']', line 25 of xxxx.sip.conf

But then all the rest of your sip peers disappear.  Obviously the error is
the lack of a closing brace.  But I would think that the impact of this
config error could be minimized if just this sip peer were tossed, and the
next sip peer were loaded normally.  With frequent manual editing of a
large sip.conf this is bound to happen sometime.  This has happened to us a
couple times, each time causing a fairly substantial outage for us as
several thousand sip peers disappear.
====================================================================== 

---------------------------------------------------------------------- 
 dtyoo - 11-13-07 15:41  
---------------------------------------------------------------------- 
qwell-

I see your point, and I'm ok with the behavior as it is.  The only thing I
would suggest is that being unable to load any sip peers due to parsing
errors would warrant an "ERROR" in the log, not just a "NOTICE". 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-13-07 15:41  dtyoo          Note Added: 0073603                          
======================================================================