[asterisk-bugs] [Zaptel 0011620]: zaptel fails on kernel 2.4.24: CFLAGS should be EXTRA_CFLAGS

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11620 
====================================================================== 
Reported By:                tzafrir
Assigned To:                
====================================================================== 
Project:                    Zaptel
Issue ID:                   11620
Category:                   General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Zaptel Version:             1.4.7.1  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             12-21-2007 21:19 CST
Last Modified:              12-23-2007 01:41 CST
====================================================================== 
Summary:                    zaptel fails on kernel 2.4.24: CFLAGS should be
EXTRA_CFLAGS
Description: 
As seen on IRC:

<nny_1> getting make[2]: Entering directory
`/usr/src/linux-headers-2.6.24-2-server'
<nny_1> scripts/Makefile.build:46: *** CFLAGS was changed in
"/usr/src/zaptel-1.4.7.1/Makefile". Fix it to use EXTRA_CFLAGS.  Stop.
<nny_1> make[2]: *** [_module_/usr/src/zaptel-1.4.7.1] Error 2
<nny_1> make[2]: Leaving directory
`/usr/src/linux-headers-2.6.24-2-server'
<nny_1> make[1]: *** [modules] Error 2
<nny_1> make[1]: Leaving directory `/usr/src/zaptel-1.4.7.1'
<nny_1> make: *** [all] Error 2


Workaround: 

1. rename Makefile.kernel26 to Kbuild
2. in Kbuild , add the line:  obj-m = zaptel.o <mod1>.o <mod1>.o
3. Build with: make MODULES="zaptel <mod1> <mod2>" [install]
====================================================================== 

---------------------------------------------------------------------- 
 tzafrir - 12-23-07 01:41  
---------------------------------------------------------------------- 
Thanks. 

But this is a problem I don't really want to ignore. CFLAGS includes flags
for userspace programs. Including some extra optimization flags that may or
may not be valid to the specific kernel configuration in question.

Therefore it is probably a bug to have them leak to the kernel build
makefile. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
12-23-07 01:41  tzafrir        Note Added: 0075861                          
======================================================================