[asterisk-bugs] [Asterisk 0011282]: [patch] Execute AGI from the CLI and the manager interface

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11282 
====================================================================== 
Reported By:                moy
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   11282
Category:                   Applications/NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     new
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 89394 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             11-17-2007 23:09 CST
Last Modified:              12-11-2007 13:00 CST
====================================================================== 
Summary:                    [patch] Execute AGI from the CLI and the manager
interface
Description: 
This new application allow to take control of the applications executed
using the Asterisk console or via AMI.

[default]
exten => _X.,1,Answer()
exten => _X.,2,DynamicApp()
exten => _X.,3,Hangup()

Once the channel enter DynamicApp, it will wait there for applications to
execute. Applications may arrive either from the console or AMI, like
this:

*CLI> dynapp SIP/testing-09124338 Playback hello-world

That will execute Playback application with hello-world arguments.

The same using AMI:

Action: AddDynApp
Channel: SIP/testing-09124338
App: Playback
Data: hello-world

I need some help of you guys to check locking/unlocking of channels, I
think I am doing right, but I am still unsure about some cases. It seems to
work though.

Comments and corrections are always welcomed.
====================================================================== 

---------------------------------------------------------------------- 
 Corydon76 - 12-11-07 13:00  
---------------------------------------------------------------------- 
Okay, couple of things:

1) you're open-coding ast_uri_encode().  Please use the API directly,
instead of coding your own version.
2) Wrap comments at 80 characters, please.
3) The command to exit should be "asyncagi break", not the other way
around.
4) Use the CALL level of AMI control, instead of inventing a new one.
5) I don't see what differentiates AGI_RESULT_SUCCESS_ASYNC from
AGI_RESULT_SUCCESS in a way that you need your own separate status.  Please
explain or remove it. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
12-11-07 13:00  Corydon76      Note Added: 0075221                          
======================================================================