<html>
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width" />
<style type="text/css">
a:hover, a:focus { text-decoration: underline !important; }
@media handheld, only screen and (max-device-width: 480px) {
div, a, p, td, th, li, dt, dd {
-webkit-text-size-adjust: auto;
}
small, small a {
-webkit-text-size-adjust: 90%;
}
small[class=email-metadata] {
-webkit-text-size-adjust: 93%;
font-size: 12px;
}
table[id=email-wrap] > tbody > tr > td {
padding: 2px !important;
}
table[id=email-wrap-inner] > tbody > tr > td {
padding: 8px !important;
}
table[id=email-footer] td {
padding: 8px 12px !important;
}
table[id=email-actions] td {
padding-top: 0 !important;
}
table[id=email-actions] td.right {
text-align: right !important;
}
table[id=email-actions] .email-list-item {
display: block;
margin: 1em 0 !important;
word-wrap: normal !important;
}
span[class=email-list-divider] {
display: none;
}
.commentsummary small[class=email-metadata] {
display: block;
}
td.comment-avatar {
padding: 8px 8px 0 8px !important;
}
.comment > td + td {
padding: 8px 8px 8px 0 !important;
}
}
</style>
</head>
<body style="font: 13px Arial, FreeSans, Helvetica, sans-serif; background: #f0f0f0; color: #505050">
<table id="email-wrap" align="center" cellpadding="0" cellspacing="0" width="100%" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; background: #f0f0f0; color: #505050">
<tbody>
<tr>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 16px">
<div id="title-status" class="successful" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; padding: 8px 0; background: #5bad5b">
<table cellpadding="0" cellspacing="0" width="100%" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; border-style: solid; border-width: 1px 0; table-layout: fixed; background: #393; border-color: #309130">
<tbody>
<tr>
<td id="title-status-icon" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 8px 0 8px 8px; width: 24px"> <img src="http://bamboo.asterisk.org/images/iconsv3/plan_successful_16.png" alt="Successful" style="border: 0; height: 16px; width: 16px" /> </td>
<td id="title-status-text" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; font-size: 16px; padding: 8px; text-shadow: 1px 1px 1px #194c19; color: #fff"> <span class="build" style="font-weight: bold"> <a href="http://bamboo.asterisk.org/browse/TESTING/" style="color: #326ca6; text-decoration: none; color: #fff">Asterisk Testing</a> › <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH/" style="color: #326ca6; text-decoration: none; color: #fff">Asterisk 1.8 Branch</a> › <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-380/" style="color: #326ca6; text-decoration: none; color: #fff">#380</a> </span> <span class="status">was successful</span> </td>
</tr>
</tbody>
</table>
</div>
<table id="email-wrap-inner" cellpadding="0" cellspacing="0" width="100%" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; background: #fff; border: 1px solid #bbb; color: #000; border-top: 0">
<tbody>
<tr>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 16px"> <p class="trigger" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; margin-top: 4px">Code has been updated by <a href="http://bamboo.asterisk.org/browse/user/mjordan" style="color: #326ca6; text-decoration: none">Matthew Jordan</a>.</p> <p class="tests-summary" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; margin-top: 4px"> All <strong>2</strong> jobs passed with <strong>360</strong> tests in total. </p>
<table width="100%" cellpadding="0" cellspacing="0" class="section-header" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; border-bottom: 1px solid #ddd; margin-top: 16px">
<tbody>
<tr>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top"> <h3 style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 19px; margin: 0"><a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-380/commit/" style="color: #326ca6; text-decoration: none">Code Changes</a></h3> </td>
<td class="utility" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; text-align: right; vertical-align: middle; white-space: nowrap"> <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-380/commit/" style="color: #326ca6; text-decoration: none">View full change details</a> </td>
</tr>
</tbody>
</table>
<table width="100%" cellpadding="0" cellspacing="0" class="commits" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; margin-top: 12px; margin-top: 8px">
<tbody>
<tr>
<td class="commit-avatar" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 4px 0; width: 24px"> <img src="https://secure.gravatar.com/avatar/519a8549643f67fe92fdb6b60f42d886.jpg?d=mm&s=24&r=g" width="24" height="24" style="border: 0; height: 24px; width: 24px" /> </td>
<td width="100%" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 4px 0; padding-left: 4px; padding-left: 8px"> <a href="http://bamboo.asterisk.org/browse/user/mjordan" style="color: #326ca6; text-decoration: none">Matthew Jordan</a><br /> Only re-create an SRTP session when needed; respond with correct crypto policy<br /> <br /> In r356604, SRTP handling was fixed to accomodate multiple crypto keys in an<br /> SDP offer and the ability to re-create an SRTP session when the crypto keys<br /> changed. In certain circumstances - most notably when a phone is put on<br /> hold after having been bridged for a significant amount of time - the act<br /> of re-creating the SRTP session causes problems for certain models of phones.<br /> The patch committed in r356604 always re-created the SRTP session regardless<br /> of whether or not the cryptographic keys changed. Since this is technically<br /> not necessary, this patch modifies the behavior to only re-create the SRTP<br /> session if Asterisk detects that the remote key has changed. This allows<br /> models of phones that do not handle the SRTP session changing to continue<br /> to work, while also providing the behavior needed for those phones that do<br /> re-negotiate cryptographic keys.<br /> <br /> In addition, in Asterisk 1.8 only, it was found that phones that offer<br /> AES_CM_128_HMAC_SHA1_32 will end up with no audio if the phone is the<br /> initiator of the call. The phone will send an INVITE request specifying<br /> that AES_CM_128_HMAC_SHA1_32 be used for the cryptographic policy; Asterisk<br /> will set its policy to that value. Unfortunately, when the call is Answered<br /> and a 200 OK is sent back to the UA, the policy sent in the response's SDP<br /> will be the hard coded value AES_CM_128_HMAC_SHA1_80. This potentially<br /> results in Asterisk using the INVITE request's policy of<br /> AES_CM_128_HMAC_SHA1_32, while the phone uses Asterisk's response of<br /> AES_CM_128_HMAC_SHA1_80. Hilarity ensues as both endpoints think the other<br /> is crazy.<br /> <br /> This patch fixes that by caching the policy from the request and responding<br /> with it. Note that this is not a problem in Asterisk 10 and later, as the<br /> ability to configure the policy was added in that version.<br /> <br /> (issue <span class="jiraIssueLink" data-issue-key="ASTERISK-20194" data-bamboo-project-key="TESTING">ASTERISK-20194</span>)<br /> Reported by: Nicolo Mazzon<br /> Tested by: Nicolo Mazzon<br /> <br /> Review: <a href="https://reviewboard.asterisk.org/r/2099" style="color: #326ca6; text-decoration: none">https://reviewboard.asterisk.org/r/2099</a><br /> <br /> </td>
<td class="revision" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 4px 0; padding-left: 4px; white-space: nowrap"> <span class="revision-id" style="background: #f0f0f0; border: 1px solid #ddd; -moz-border-radius: 3px; -webkit-border-radius: 3px; border-radius: 3px; display: inline-block; font-family: monospace; line-height: 1; max-width: 5em; overflow: hidden; padding: 2px 4px; text-overflow: ellipsis; vertical-align: top; white-space: nowrap; color: #505050">372709</span> </td>
</tr>
</tbody>
</table>
<table width="100%" cellpadding="0" cellspacing="0" class="section-header" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; border-bottom: 1px solid #ddd; margin-top: 16px">
<tbody>
<tr>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top"> <h3 style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 19px; margin: 0"><a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-380/test" style="color: #326ca6; text-decoration: none">Tests</a></h3> </td>
<td class="utility" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; text-align: right; vertical-align: middle; white-space: nowrap"> <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-380/test" style="color: #326ca6; text-decoration: none">View full test details</a> </td>
</tr>
</tbody>
</table> <h4 style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 17px; margin-top: 12px">2 Fixed Tests</h4>
<table width="100%" cellpadding="0" cellspacing="0" class="aui tests" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; margin-top: 4px">
<thead style="border-bottom: 1px solid #bbb">
<tr>
<th colspan="2" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; font-weight: bold; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; background: #f0f0f0; color: #000">Test</th>
<th style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; font-weight: bold; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; background: #f0f0f0; color: #000">Job</th>
</tr>
</thead>
<tbody>
<tr style="background: #fff; border-bottom: 1px solid #ddd; color: #111">
<td class="status-icon" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; width: 16px; padding-bottom: 0; padding-right: 0"> <img src="http://bamboo.asterisk.org/images/iconsv3/plan_successful_16.png" style="border: 0; height: 16px; width: 16px" /> </td>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left"> <span class="test-class">AsteriskTestSuite</span> <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-AST18CENTOS32-380/test/case/16778977" class="test-name" style="color: #326ca6; text-decoration: none">tests/apps/voicemail/check_voicemail_forward</a> </td>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left"> <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-AST18CENTOS32-380/test" style="color: #326ca6; text-decoration: none">Asterisk 1.8 CentOS 6 32-Bit</a> </td>
</tr>
<tr style="background: #fff; border-bottom: 1px solid #ddd; color: #111">
<td class="status-icon" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; width: 16px; padding-bottom: 0; padding-right: 0"> <img src="http://bamboo.asterisk.org/images/iconsv3/plan_successful_16.png" style="border: 0; height: 16px; width: 16px" /> </td>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left"> <span class="test-class">AsteriskTestSuite</span> <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-AST18CENTOS32-380/test/case/16778970" class="test-name" style="color: #326ca6; text-decoration: none">tests/cdr/console_dial_sip_congestion</a> </td>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left"> <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-AST18CENTOS32-380/test" style="color: #326ca6; text-decoration: none">Asterisk 1.8 CentOS 6 32-Bit</a> </td>
</tr>
</tbody>
</table>
<table width="100%" cellpadding="0" cellspacing="0" id="email-actions" class="email-metadata" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; border-top: 1px solid #bbb; color: #505050; margin: 16px 0 0; padding: 0; color: #505050">
<tbody>
<tr>
<td class="left" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding-top: 8px"> <span class="email-list-item"><a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-380" style="color: #326ca6; text-decoration: none">View Online</a></span> <span class="email-list-divider" style="color: #505050; padding: 0 0.350em">|</span> <span class="email-list-item"><a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-380?commentMode=true" style="color: #326ca6; text-decoration: none">Add Comments</a></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<table id="email-footer" cellpadding="0" cellspacing="0" width="100%" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit">
<tbody>
<tr>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 16px; text-align: center"> <p style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 11px; margin: 0"><small style="font-size: 11px">This message was sent by <a href="http://bamboo.asterisk.org" style="color: #326ca6; text-decoration: none">Atlassian Bamboo</a>.</small></p> <p style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 11px; margin: 0; margin-top: 4px"><small style="font-size: 11px">If you wish to stop receiving these emails edit your <a href="http://bamboo.asterisk.org/profile/userNotifications.action" style="color: #326ca6; text-decoration: none">user profile</a> or <a href="http://bamboo.asterisk.org/viewAdministrators.action" style="color: #326ca6; text-decoration: none">notify your administrator</a>.</small></p> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>