<div>
<style type="text/css">
.successful a, .successful a:visited, .successful a:link, .successful a:hover,.successful a:active {color:#393}
.failed a, .failed a:visited, .failed a:link, .failed a:hover,.failed a:active {color:#d62829}
.notexecuted a, .notexecuted a:visited, .notexecuted a:link, .notexecuted a:hover,.notexecuted a:active {color:#ffcc66}
td a, td a:link, td a:visited, td a:hover, td a:active {background:transparent;font-family: Arial, sans-serif;text-decoration:underline;}
td a:link {color:#369;}
td a:visited {color:#444;}
td a:hover, td a:active {color:#036;}
td a:hover {text-decoration:none;}
</style>
<font size="2" color="black" face="Arial, Helvetica, sans-serif" style="font-family: Arial, sans-serif;font-size: 13px;color:#000">
<table align="center" border="0" cellpadding="5" cellspacing="0" width="98%">
<tr>
<td style="vertical-align:top">
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffe6e7;border-top:1px solid #eec0c0;border-bottom:1px solid #eec0c0;color:#d62829;">
<tr>
<td width="20" style="vertical-align:top;padding:5px 0 5px 10px">
<img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#d62829;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST18/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">Asterisk - 1.8</a> >
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">Compile</a> >
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-26/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">#26</a>
<span class="failed" style="font-family: Arial, sans-serif; font-size: 14px;"> has failed.</span>
<span class="failed" style="font-family: Arial, sans-serif; font-size: 13px;">
<br/>Code has been updated by <a href="http://bamboo.asterisk.org/browse/user/mjordan">Matthew Jordan</a>.
<br/><strong>4/6</strong> jobs failed, no tests found.
</span>
</td>
</tr>
</table>
<br>
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-26/" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Failing Jobs</a>
</td>
<td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
</td>
</tr>
</table>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr>
<td width="20" style="vertical-align:top;padding:11px 0 5px 10px; border-bottom:1px solid #EEEEEE; ">
<img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
</td>
<td style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;">
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-MAVERICKAMD64-26/" style="color:red;">pbuilder-maverick-amd64</a>
<span style="color:#444444; font-size:11px; font-style:italic;">(Compile packages)</span>
</td>
<td width="120" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
<b>Duration:</b> 8 minutes
</td>
<td width="130" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
<b>Tests:</b> No tests found
</td>
<td width="80" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;font-size:11px">
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-MAVERICKAMD64-26/log">Logs</a> | <a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-MAVERICKAMD64-26/artifact">Artifacts</a>
</td>
</tr>
<tr>
<td width="20" style="vertical-align:top;padding:11px 0 5px 10px; border-bottom:1px solid #EEEEEE; ">
<img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
</td>
<td style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;">
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-NATTYAMD64-26/" style="color:red;">pbuilder-natty-amd64</a>
<span style="color:#444444; font-size:11px; font-style:italic;">(Compile packages)</span>
</td>
<td width="120" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
<b>Duration:</b> 7 minutes
</td>
<td width="130" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
<b>Tests:</b> No tests found
</td>
<td width="80" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;font-size:11px">
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-NATTYAMD64-26/log">Logs</a> | <a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-NATTYAMD64-26/artifact">Artifacts</a>
</td>
</tr>
<tr>
<td width="20" style="vertical-align:top;padding:11px 0 5px 10px; border-bottom:1px solid #EEEEEE; ">
<img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
</td>
<td style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;">
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-ONEIRICAMD64-26/" style="color:red;">pbuilder-oneiric-amd64</a>
<span style="color:#444444; font-size:11px; font-style:italic;">(Compile packages)</span>
</td>
<td width="120" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
<b>Duration:</b> 4 minutes
</td>
<td width="130" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
<b>Tests:</b> No tests found
</td>
<td width="80" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;font-size:11px">
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-ONEIRICAMD64-26/log">Logs</a> | <a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-ONEIRICAMD64-26/artifact">Artifacts</a>
</td>
</tr>
<tr>
<td width="20" style="vertical-align:top;padding:11px 0 5px 10px; border-bottom:1px solid #EEEEEE; ">
<img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
</td>
<td style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;">
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-PRECISEAMD64-26/" style="color:red;">pbuilder-precise-amd64</a>
<span style="color:#444444; font-size:11px; font-style:italic;">(Compile packages)</span>
</td>
<td width="120" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
<b>Duration:</b> 5 minutes
</td>
<td width="130" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
<b>Tests:</b> No tests found
</td>
<td width="80" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;font-size:11px">
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-PRECISEAMD64-26/log">Logs</a> | <a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-PRECISEAMD64-26/artifact">Artifacts</a>
</td>
</tr>
</table>
<br/>
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-26/commit/" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Code Changes</a>
</td>
<td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-26/commit/" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">See full change details</a><img src="http://bamboo.asterisk.org/images/icons/more.gif" width="15" height="15" style="vertical-align:middle;padding:2px">
</td>
</tr>
</table>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr><td width="20" style="vertical-align:top;padding:10px 0 0px 10px">
<img src="http://bamboo.asterisk.org/images/icons/businessman.gif" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:10px 10px 0px 10px">
<a href="http://bamboo.asterisk.org/browse/user/mjordan" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000">
Matthew Jordan</a><br>
Fix potential buffer overrun and memory leak when executing "sip show peers"<br/>
<br/>
The "sip show peers" command uses a fix sized array to sort the current peers<br/>
in the peers ao2_container. The size of the array is based on the current<br/>
number of peers in the container. However, once the size of the array is<br/>
determined, the number of peers in the container can change, as the peers<br/>
container is not locked. This could cause a buffer overrun when populating<br/>
the array, if peers were added to the container after the array was created.<br/>
Additionally, a memory leak of the allocated array would occur if a user<br/>
caused the _show_peers method to return CLI_SHOWUSAGE.<br/>
<br/>
We now create a snapshot of the current peers using an ao2_callback with the<br/>
OBJ_MULTIPLE flag. This size of the array is set to the number of peers<br/>
that the iterator will iterate over; hence, if peers are added or removed<br/>
from the peers container it will not affect the execution of the "sip show<br/>
peers" command.<br/>
<br/>
Review: <a href="https://reviewboard.asterisk.org/r/1738/">https://reviewboard.asterisk.org/r/1738/</a><br/>
<br/>
(closes issue ASTERISK-19231)<br/>
(closes issue ASTERISK-19361)<br/>
Reported by: Thomas Arimont, Jamuel Starkey<br/>
Tested by: Thomas Arimont, Jamuel Starkey<br/>
Patches: sip_show_peers_2012_02_16.diff uploaded by mjordan (license 6283)<br/>
<br/>
<br/>
</td>
<td width="60" style="font-family: Arial, sans-serif; font-size: 13px; ;color:#036;vertical-align:top;padding:10px 10px 0px 10px">
(356214)
</td></tr>
</table><br>
</td>
<td width="150" style="vertical-align:top">
<table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;vertical-align:top;padding:5px 10px">
Actions
</td>
</tr>
</table>
<table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#f5f9fc;border-bottom:1px solid #bbd0e5;">
<tr>
<td style="font-family: Ariel, sans-serif; font-size: 13px; color:#036;vertical-align:top;padding:5px 10px;line-height:1.7">
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-26" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">View Online</a>
<br>
<a href="http://bamboo.asterisk.org/browse/AST18-COMPILE-26?commentMode=true" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">Add Comments</a>
<br>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr><td colspan="2" align="center" style="font-family: Arial, sans-serif;text-align:center;font-size:11px;font-weight:bold;color:#999;vertical-align:top;padding:20px">
Email generated by <a href="http://bamboo.asterisk.org" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">Atlassian Bamboo</a> - if you wish to stop receiving these emails edit your <a href="http://bamboo.asterisk.org/profile/userNotifications.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">user profile</a> or <a href="http://bamboo.asterisk.org/viewAdministrators.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">notify your administrator</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</font>
</div>