<div>
<style type="text/css">
.successful a, .successful a:visited, .successful a:link, .successful a:hover,.successful a:active {color:#393}
.failed a, .failed a:visited, .failed a:link, .failed a:hover,.failed a:active {color:#d62829}
.notexecuted a, .notexecuted a:visited, .notexecuted a:link, .notexecuted a:hover,.notexecuted a:active {color:#ffcc66}
td a, td a:link, td a:visited, td a:hover, td a:active {background:transparent;font-family: Arial, sans-serif;text-decoration:underline;}
td a:link {color:#369;}
td a:visited {color:#444;}
td a:hover, td a:active {color:#036;}
td a:hover {text-decoration:none;}
</style>
<font size="2" color="black" face="Arial, Helvetica, sans-serif" style="font-family: Arial, sans-serif;font-size: 13px;color:#000">
<table align="center" border="0" cellpadding="5" cellspacing="0" width="98%">
<tr>
<td style="vertical-align:top">
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffe6e7;border-top:1px solid #eec0c0;border-bottom:1px solid #eec0c0;color:#d62829;">
<tr>
<td width="20" style="vertical-align:top;padding:5px 0 5px 10px">
<img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#d62829;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST10/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">Asterisk - 10</a> >
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">Ubuntu Lucid (10.04)</a> >
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-910/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">#910</a>
<span class="failed" style="font-family: Arial, sans-serif; font-size: 14px;"> has failed.</span>
<span class="failed" style="font-family: Arial, sans-serif; font-size: 13px;">
<br/>Code has been updated by <a href="http://bamboo.asterisk.org/browse/user/twilson">Terry Wilson</a>, <a href="http://bamboo.asterisk.org/browse/user/russell">Russell Bryant</a>.
<br/><strong>2/195</strong> tests failed.
</span>
</td>
</tr>
</table>
<br>
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-910/" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Failing Jobs</a>
</td>
<td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
</td>
</tr>
</table>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr>
<td width="20" style="vertical-align:top;padding:11px 0 5px 10px; border-bottom:1px solid #EEEEEE; ">
<img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
</td>
<td style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-AMD64-910/" style="color:red;">amd64</a>
<span style="color:#444444; font-size:11px; font-style:italic;">(Default Stage)</span>
</td>
<td width="120" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
<b>Duration:</b> 70 minutes
</td>
<td width="130" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
<b>Tests:</b> 2 of 195 failed
</td>
<td width="80" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;font-size:11px">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-AMD64-910/log">Logs</a> | <a href="http://bamboo.asterisk.org/browse/AST10-LUCID-AMD64-910/artifact">Artifacts</a>
</td>
</tr>
</table>
<br/>
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-910/commit/" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Code Changes</a>
</td>
<td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-910/commit/" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">See full change details</a><img src="http://bamboo.asterisk.org/images/icons/more.gif" width="15" height="15" style="vertical-align:middle;padding:2px">
</td>
</tr>
</table>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr><td width="20" style="vertical-align:top;padding:10px 0 0px 10px">
<img src="http://bamboo.asterisk.org/images/icons/businessman.gif" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:10px 10px 0px 10px">
<a href="http://bamboo.asterisk.org/browse/user/russell" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000">
Russell Bryant</a><br>
Merged revisions 351182 via svnmerge from <br/>
<a href="https://origsvn.digium.com/svn/asterisk/branches/1.8">https://origsvn.digium.com/svn/asterisk/branches/1.8</a><br/>
<br/>
........<br/>
r351182 | russell | 2012-01-16 20:37:03 -0500 (Mon, 16 Jan 2012) | 22 lines<br/>
<br/>
Add some missing locking in chan_sip.<br/>
<br/>
This patch adds some missing locking to the function <br/>
send_provisional_keepalive_full(). This function is called from the scheduler,<br/>
which is processed in the SIP monitor thread. The associated channel (or pbx)<br/>
thread will also be using the same sip_pvt and ast_channel so locking must be<br/>
used. The sip_pvt_lock_full() function is used to ensure proper locking order<br/>
in a safe manner.<br/>
<br/>
In passing, document a suspected reference counting error in this function.<br/>
The "fix" is left commented out because when the "fix" is present, crashes<br/>
occur. My theory is that fixing it is exposing a reference counting error<br/>
elsewhere, but I don't know where. (Or my analysis of this being a problem<br/>
could have been completely wrong in the first place). Leave the comment in<br/>
the code for so that someone may investigate it again in the future.<br/>
<br/>
Also add a bit of doxygen to transmit_provisional_response().<br/>
<br/>
(closes issue ASTERISK-18979)<br/>
<br/>
Review: <a href="https://reviewboard.asterisk.org/r/1648">https://reviewboard.asterisk.org/r/1648</a><br/>
........<br/>
</td>
<td width="60" style="font-family: Arial, sans-serif; font-size: 13px; ;color:#036;vertical-align:top;padding:10px 10px 0px 10px">
(351183)
</td></tr>
<tr><td width="20" style="vertical-align:top;padding:10px 0 0px 10px">
<img src="http://bamboo.asterisk.org/images/icons/businessman.gif" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:10px 10px 0px 10px">
<a href="http://bamboo.asterisk.org/browse/user/twilson" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000">
Terry Wilson</a><br>
Ensure ACK retransmit & hangup on non-200 response to INVITE<br/>
<br/>
When handling a non-2xx final response on an INVITE transaction, we have to<br/>
keep the transaction around after we send an ACK in case we receive a<br/>
retransmission of the response so we can re-transmit the ACK, but also tear<br/>
down the ast_channel as soon as we transmit the ACK. Before this patch, we<br/>
could fail at both of these things. Calling sip_alreadygone/needdestroy<br/>
prevented us from keeping the transaction up and retransmitting the ACK, and<br/>
queueing CONGESTION was not sufficient to cause the channel to be torn down<br/>
when originating calls via the CLI, for example.<br/>
<br/>
This patch queues a hangup with CONGESTION instead of just queueing CONGESTION<br/>
for these responses and removes the sip_alreadygone and sip_needdestroy calls<br/>
from handle_response_invite on non-2xx responses. It relies on the hangup<br/>
calling sip_scheddestroy.<br/>
<br/>
For more information, see section 17.1.1.1 of RFC 3261.<br/>
<br/>
(closes issue ASTERISK-17717)<br/>
Review: <a href="https://reviewboard.asterisk.org/r/1672/">https://reviewboard.asterisk.org/r/1672/</a><br/>
........<br/>
<br/>
Merged revisions 351130 from <a href="http://svn.asterisk.org/svn/asterisk/branches/1.8">http://svn.asterisk.org/svn/asterisk/branches/1.8</a><br/>
</td>
<td width="60" style="font-family: Arial, sans-serif; font-size: 13px; ;color:#036;vertical-align:top;padding:10px 10px 0px 10px">
(351131)
</td></tr>
</table><br>
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;vertical-align:top;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-910/test" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Tests</a>
</td>
<td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-910/test" style="font-family: Arial, sans-serif; font-size: 13px;color:#036">See full test details</a><img src="http://bamboo.asterisk.org/images/icons/more.gif" width="15" height="15" style="vertical-align:middle;padding:2px">
</td>
</tr>
</table>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr>
<td colspan="2" width="100%" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000;vertical-align:top;padding:10px 0 0 10px">
New Test Failures (1)
</td>
</tr>
<tr>
<td width="20" style="vertical-align:top;padding:5px 0 5px 10px">
<img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:5px 10px">
AsteriskTestSuite :
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-AMD64-910/test/case/15827248" style="font-family: Arial, sans-serif; font-size: 13px;color:#000">S/channels/ s i p/codec negotiation</a>
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-AMD64-910/test" style="font-family: Arial, sans-serif; font-size: 13px;color:#999">(amd64)</a>
</td>
</tr> <tr>
<td colspan="2" width="100%" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000;vertical-align:top;padding:10px 0 0 10px">
Existing Test Failures (1)
</td>
</tr>
<tr>
<td width="20" style="vertical-align:top;padding:5px 0 5px 10px">
<img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:5px 10px">
AsteriskTestSuite :
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-AMD64-910/test/case/13599059" style="font-family: Arial, sans-serif; font-size: 13px;color:#000">S/fax/gateway mix2</a>
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-AMD64-910/test" style="font-family: Arial, sans-serif; font-size: 13px;color:#999">(amd64)</a>
</td>
</tr> </table><br>
</td>
<td width="150" style="vertical-align:top">
<table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;vertical-align:top;padding:5px 10px">
Actions
</td>
</tr>
</table>
<table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#f5f9fc;border-bottom:1px solid #bbd0e5;">
<tr>
<td style="font-family: Ariel, sans-serif; font-size: 13px; color:#036;vertical-align:top;padding:5px 10px;line-height:1.7">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-910" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">View Online</a>
<br>
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-910?commentMode=true" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">Add Comments</a>
<br>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr><td colspan="2" align="center" style="font-family: Arial, sans-serif;text-align:center;font-size:11px;font-weight:bold;color:#999;vertical-align:top;padding:20px">
Email generated by <a href="http://bamboo.asterisk.org" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">Atlassian Bamboo</a> - if you wish to stop receiving these emails edit your <a href="http://bamboo.asterisk.org/profile/userNotifications.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">user profile</a> or <a href="http://bamboo.asterisk.org/viewAdministrators.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">notify your administrator</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</font>
</div>