<div>
<style type="text/css">
.successful a, .successful a:visited, .successful a:link, .successful a:hover,.successful a:active {color:#393}
.failed a, .failed a:visited, .failed a:link, .failed a:hover,.failed a:active {color:#d62829}
.notexecuted a, .notexecuted a:visited, .notexecuted a:link, .notexecuted a:hover,.notexecuted a:active {color:#ffcc66}
td a, td a:link, td a:visited, td a:hover, td a:active {background:transparent;font-family: Arial, sans-serif;text-decoration:underline;}
td a:link {color:#369;}
td a:visited {color:#444;}
td a:hover, td a:active {color:#036;}
td a:hover {text-decoration:none;}
</style>
<font size="2" color="black" face="Arial, Helvetica, sans-serif" style="font-family: Arial, sans-serif;font-size: 13px;color:#000">
<table align="center" border="0" cellpadding="5" cellspacing="0" width="98%">
<tr>
<td style="vertical-align:top">
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffe6e7;border-top:1px solid #eec0c0;border-bottom:1px solid #eec0c0;color:#d62829;">
<tr>
<td width="20" style="vertical-align:top;padding:5px 0 5px 10px">
<img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#d62829;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST10/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">Asterisk - 10</a> >
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">Ubuntu Lucid (10.04)</a> >
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-284/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">#284</a>
<span class="failed" style="font-family: Arial, sans-serif; font-size: 14px;"> has failed.</span>
<span class="failed" style="font-family: Arial, sans-serif; font-size: 13px;">
<br/>Code has been updated by <a href="http://bamboo.asterisk.org/browse/user/twilson">Terry Wilson</a>.
<br/>No failed tests found, a possible compilation error.
</span>
</td>
</tr>
</table>
<br>
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-284/" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Failing Jobs</a>
</td>
<td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
</td>
</tr>
</table>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr>
<td width="20" style="vertical-align:top;padding:11px 0 5px 10px; border-bottom:1px solid #EEEEEE; ">
<img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
</td>
<td style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-AMD64-284/" style="color:red;">amd64</a>
<span style="color:#444444; font-size:11px; font-style:italic;">(Default Stage)</span>
</td>
<td width="120" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
<b>Duration:</b> 1 minute
</td>
<td width="130" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
<b>Tests:</b> No tests found
</td>
<td width="80" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;font-size:11px">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-AMD64-284/log">Logs</a> | <a href="http://bamboo.asterisk.org/browse/AST10-LUCID-AMD64-284/artifact">Artifacts</a>
</td>
</tr>
</table>
<br/>
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-284/commit/" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Code Changes</a>
</td>
<td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-284/commit/" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">See full change details</a><img src="http://bamboo.asterisk.org/images/icons/more.gif" width="15" height="15" style="vertical-align:middle;padding:2px">
</td>
</tr>
</table>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr><td width="20" style="vertical-align:top;padding:10px 0 0px 10px">
<img src="http://bamboo.asterisk.org/images/icons/businessman.gif" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:10px 10px 0px 10px">
<a href="http://bamboo.asterisk.org/browse/user/twilson" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000">
Terry Wilson</a><br>
Simplify queue membercount code<br/>
<br/>
Despite an ominous sounding comment stating that membercount was for "logged<br/>
in" members only and thus we couldn't use ao2_container_count(), I could not<br/>
find a single place in the code where that seemed to be accurate. The only time<br/>
we decremented membercount was when we were marking something dead or actually<br/>
removing it. The only places we incremented it were either after ao2_link(), or<br/>
trying to correct for having set it to 0 during a reload. In every case where<br/>
we were correcting the value, it seemed that we were trying to make the count<br/>
actually match what ao2_container_count() would return. The only place I could<br/>
find where we made a determination about something being "logged in" or not, we<br/>
didn't trust the membercount, but instead looked at devicestate, paused, etc.<br/>
<br/>
This patch removes membercount, replaces its use with ao2_container_count, and<br/>
manually adds the results of ao2_container_count to a "membercount" field for<br/>
ast_data queue query results. This patch also would fix AST-676, but as it is<br/>
slightly riskier than the previously committed fix, the two commits have been<br/>
made separately.<br/>
<br/>
Reivew: <a href="https://reviewboard.asterisk.org/r/1541/">https://reviewboard.asterisk.org/r/1541/</a><br/>
........<br/>
<br/>
Merged revisions 342383 from <a href="http://svn.asterisk.org/svn/asterisk/branches/1.8">http://svn.asterisk.org/svn/asterisk/branches/1.8</a><br/>
</td>
<td width="60" style="font-family: Arial, sans-serif; font-size: 13px; ;color:#036;vertical-align:top;padding:10px 10px 0px 10px">
(342384)
</td></tr>
</table><br>
</td>
<td width="150" style="vertical-align:top">
<table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;vertical-align:top;padding:5px 10px">
Actions
</td>
</tr>
</table>
<table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#f5f9fc;border-bottom:1px solid #bbd0e5;">
<tr>
<td style="font-family: Ariel, sans-serif; font-size: 13px; color:#036;vertical-align:top;padding:5px 10px;line-height:1.7">
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-284" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">View Online</a>
<br>
<a href="http://bamboo.asterisk.org/browse/AST10-LUCID-284?commentMode=true" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">Add Comments</a>
<br>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr><td colspan="2" align="center" style="font-family: Arial, sans-serif;text-align:center;font-size:11px;font-weight:bold;color:#999;vertical-align:top;padding:20px">
Email generated by <a href="http://bamboo.asterisk.org" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">Atlassian Bamboo</a> - if you wish to stop receiving these emails edit your <a href="http://bamboo.asterisk.org/profile/userNotifications.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">user profile</a> or <a href="http://bamboo.asterisk.org/viewAdministrators.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">notify your administrator</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</font>
</div>