[test-results] [Bamboo] Asterisk > Asterisk Full Build > #1019 has FAILED. Change made by George Joseph.
Bamboo
noreply at bamboo.asterisk.org
Fri Apr 10 01:08:06 CDT 2015
-----------------------------------------------------------------------
Asterisk > Asterisk Full Build > #1019 failed.
-----------------------------------------------------------------------
This build occurred because it is a dependant of AST-ATRUNKBUILD-1761.
2/2 jobs failed, no tests found.
https://bamboo.asterisk.org/bamboo/browse/AST-ATRUNKFULLBUILD-1019/
---------------------
Currently Responsible
---------------------
Matt Jordan (Automatically assigned)
Mark Michelson (Automatically assigned)
Richard Mudgett (Automatically assigned)
--------------
Failing Jobs
--------------
- CentOS 6 32-Bit Basic Build (Basic Build): No tests found.
- CentOS 6 64-Bit Basic Build (Basic Build): No tests found.
--------------
Code Changes
--------------
George Joseph (434547):
>res_pjsip_phoneprov_provider: Fix reference leak on unload
>
>res_pjsip_phoneprov_provider was leaking references to phoneprov objects due to
>a missing OBJ_NODATA in an ao2_callback in load_users(). Rather than adding the
>OBJ_NODATA, I changed load_users to use a more straightforward ao2_iterator.
>This plugged the leak but exposed an unload order issue between
>res_pjsip_phoneprov_provider, res_phoneprov and res_pjsip.
>
>res_pjsip_phoneprov_provider unloads first, then res_phoneprov, then res_pjsip.
>Since res_pjsip_phoneprov_provider uses res_pjsip's sorcery instance, when it
>unloads, it's objects are still in the sorcery instance. When res_pjsip
>unloads, it destroys all its objects including res_pjsip_phoneprov_provider's.
>The phoneprov destructor then attempts to unregister the extension from
>res_phoneprov but because res_phoneprov is already cleaned up, its users
>container is gone and we get a FRACK.
>
>Simple solution, check for the NULL users container before attempting to remove
>the entry. Duh.
>
>Ran tests/res_phoneprov/res_phoneprov_provider. No leaks in
>res_pjsip_phoneprov_provider and no FRACKs.
>
>Reported-by: Corey Farrell
>Tested-by: George Joseph
>Review: https://reviewboard.asterisk.org/r/4608/
>ASTERISK-24935 #close
>........
>
>Merged revisions 434545 from http://svn.asterisk.org/svn/asterisk/branches/13
>
George Joseph (434546):
>loader/main: Don't set ast_fully_booted until deferred reloads are processed
>
>Until we have a true module management facility it's sometimes necessary for one
>module to force a reload on another before its own load is complete. If
>Asterisk isn't fully booted yet, these reloads are deferred. The problem is
>that asterisk reports fully booted before processing the deferred reloads which
>means Asterisk really isn't quite ready when it says it is.
>
>This patch moves the report of fully booted after the processing of the deferred
>reloads is complete.
>
>Since the pjsip stack has the most number of related modules, I ran the
>channels/pjsip testsuite to make sure there aren't any issues. All tests
>passed.
>
>Tested-by: George Joseph
>Review: https://reviewboard.asterisk.org/r/4604/
>........
>
>Merged revisions 434544 from http://svn.asterisk.org/svn/asterisk/branches/13
>
--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20150410/225d0f09/attachment-0001.html>
More information about the Test-results
mailing list