[test-results] [Bamboo] Asterisk - Team Branches > Pimp My SIP > #325 has FAILED (1 tests failed, no failures were new). Change made by root.
Bamboo
bamboo at asterisk.org
Thu May 9 13:46:54 CDT 2013
-----------------------------------------------------------------------
Asterisk - Team Branches > Pimp My SIP > #325 failed.
-----------------------------------------------------------------------
Code has been updated by root.
1/2 jobs failed, with 1 failing test, no failures were new.
http://bamboo.asterisk.org/browse/ASTTEAM-PIMPMYSIP-325/
--------------
Failing Jobs
--------------
- Asterisk 1.8 CentOS 6 32-Bit (CentOS 6): 1 of 306 tests failed.
--------------
Code Changes
--------------
root (388117):
>Multiple revisions 388110,388113
>
>........
> r388110 | elguero | 2013-05-08 22:35:25 -0500 (Wed, 08 May 2013) | 26 lines
>
> Fix Segfault In app_queue When "persistentmembers" Is Enabled And Using Realtime
>
> When the "ignorebusy" setting was deprecated, we added some code to allow us to
> be compatible with older setups that are still using the "ignorebusy" setting
> instead of "ringinuse". We set a char *variable with the column name to use,
> which helps the realtime functions to use the correct column in their SQL
> queries. When "persistentmembers" is enabled, we are not setting this variable
> before the realtime functions were called to load members. This results in the
> variable being NULL and therefore causing a segfault when loading members during
> the module's process of loading.
>
> The solution was to move the code that sets that variable to be before these
> realtime functions are called during the loading of the module.
>
> (closes issue ASTERISK-21738)
> Reported by: JoshE
> Tested by: JoshE
> Patches:
> asterisk-21738-rt-ringinuse-field-not-set.diff
> uploaded by Michael L. Young (license 5026)
>
> Review: https://reviewboard.asterisk.org/r/2499/
> ........
>
> Merged revisions 388108 from http://svn.asterisk.org/svn/asterisk/branches/11
>........
> r388113 | elguero | 2013-05-08 23:11:59 -0500 (Wed, 08 May 2013) | 33 lines
>
> Fix The Payload Being Set On CN Packets And Do Not Set Marker Bit
>
> When we send out a CN packet (for instance, in the case of using rtpkeepalives),
> we are not setting the payload code properly. Also, we are setting the marker
> bit when we shouldn't be according to RFC 3389, section 4.
>
> AST_RTP_CN is not defined by AST_FORMAT codes. Therefore, we should be using
> ast_rtp_codecs_payload_code() rather than ast_rtp_codecs_payload_lookup().
>
> 11 and trunk already use the appropriate function.
>
> * In 1.8, use ast_rtp_codecs_payload_code()
>
> * Remove the setting of the marker bit
>
> * Fix the debug message by incrementing the seqno after the debug message is set
> in order to display the correct seqno that was sent out
>
> (closes issue ASTERISK-21246)
> Reported by: Peter Katzmann
> Tested by: Peter Katzmann, Michael L. Young
> Patches:
> asterisk-21246-rtp-cng-payload-error_1.8_v2.diff
> uploaded by Michael L. Young (license 5026)
>
> Review: https://reviewboard.asterisk.org/r/2500/
> ........
>
> Merged revisions 388111 from http://svn.asterisk.org/svn/asterisk/branches/1.8
> ........
>
> Merged revisions 388112 from http://svn.asterisk.org/svn/asterisk/branches/11
>........
>
>Merged revisions 388110,388113 from file:///srv/subversion/repos/asterisk/trunk
>
--------------
Tests
--------------
Existing Test Failures (1)
- AsteriskTestSuite: S/channels/gulp/srtp negotiation
Fixed Tests (1)
- AsteriskUnitTests: /main/threadpool/auto increment
--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20130509/18a24716/attachment-0001.htm>
More information about the Test-results
mailing list