[test-results] [Bamboo] Asterisk Testing > Asterisk Trunk > #1226 has FAILED (5 tests failed, no failures were new). Change made by Matthew Jordan.

[Bamboo]

-----------------------------------------------------------------------
Asterisk Testing > Asterisk Trunk > #1226 failed.
-----------------------------------------------------------------------
Code has been updated by Matthew Jordan.
1/2 jobs failed, with 5 failing tests, no failures were new.

http://bamboo.asterisk.org/browse/TESTING-ASTERISKTRUNK-1226/


--------------
Failing Jobs
--------------
  - Asterisk CentOS 6 32-Bit (CentOS 6): 5 of 533 tests failed.



--------------
Code Changes
--------------
Matthew Jordan (387039):

>Fix CDR not being created during an externally initiated blind transfer
>
>Way back when in the dark days of Asterisk 1.8.9, blind transferring a call
>in a context that included the 'h' extension would inadvertently execute the
>hangup code logic on the transferred channel. This was a "bad thing". The fix
>was to properly check for the softhangup flags on the channel and only execute
>the 'h' extension logic (and, in later versions, hangup handler logic) if the
>channel was well and truly dead (Jim).
>
>Unfortunately, CDRs are fickle. Setting the softhangup flag when we detected
>that the channel was leaving the bridge (but not to die) caused some crucial
>snippet of CDR code, lying in ambush in the middle of the bridging code, to
>not get executed. This had the effect of blowing away one of the CDRs that is
>typically created during a blind transfer.
>
>While we live and die by the adage "don't touch CDRs in release branches", this
>was our bad. The attached patch restores the CDR behavior, and still manages to
>not run the 'h' extension during a blind transfer (at least not when it's
>supposed to).
>
>Thanks to Steve Davies for diagnosing this and providing a fix.
>
>Review: https://reviewboard.asterisk.org/r/2476
>
>(closes issue ASTERISK-21394)
>Reported by: Ishfaq Malik
>Tested by: Ishfaq Malik, mjordan
>patches:
>  fix_missing_blindXfer_cdr2 uploaded by one47 (License 5012)
>........
>
>Merged revisions 387036 from http://svn.asterisk.org/svn/asterisk/branches/1.8
>........
>
>Merged revisions 387038 from http://svn.asterisk.org/svn/asterisk/branches/11
>



--------------
Tests
--------------
Existing Test Failures (5)
   - AsteriskTestSuite: S/apps/directory attendant exit
   - AsteriskTestSuite: S/channels/ s i p/sip tls call
   - AsteriskTestSuite: S/bridge/transfer failure
   - AsteriskTestSuite: S/apps/directory operator exit
   - AsteriskTestSuite: S/apps/confbridge/confbridge marked
Fixed Tests (1)
   - AsteriskTestSuite: S/channels/ s i p/sip custom presence/multiple state change

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20130501/04dae63f/attachment-0001.htm>