[test-results] [Bamboo] Asterisk Testing > Asterisk Trunk > #969 has FAILED (1 tests failed). Change made by Matthew Jordan.

[Bamboo]

-----------------------------------------------------------------------
Asterisk Testing > Asterisk Trunk > #969 failed.
-----------------------------------------------------------------------
Code has been updated by Matthew Jordan.
1/370 tests failed.

http://bamboo.asterisk.org/browse/TESTING-ASTERISKTRUNK-969/


--------------
Failing Jobs
--------------
  - Asterisk CentOS 6 32-Bit (CentOS 6): 1 of 370 tests failed.



--------------
Code Changes
--------------
Matthew Jordan (380332):

>Ensure that a declined media stream is terminated with a '\r\n'
>
>In r369028, chan_sip's processing of media streams in an SDP was modified to
>better handle multiple offered media streams. Part of that change modified
>how streams were declined. Previously, declined media streams were not
>handled in an RFC compliant manner; now, we set the port number to 0 in the
>media stream definition and proceed on with the next media stream.
>
>Unfortunately, the formatting of the declined media stream forgot to append a
>'\r\n' to the end of the media stream. This is normally added to the accepted
>media streams later on in the processing of the SDP. Since the declined media
>stream uses a different buffer than the accepted media streams (and is a
>malloc'd buffer as opposed to a struct ast_str), it's easier to just slap the
>'\r\n' on the declined media stream buffer rather than attempt to append it
>later on.
>
>So, that's what we do. And now some devices (and probably some providers) will
>be a bit happier (but probably not terribly happy, since we just rejected
>something they offered).
>
>Review: https://reviewboard.asterisk.org/r/2297/
>
>(closes issue ASTERISK-20908)
>Reported by: Dennis DeDonatis
>Tested by: Dennis DeDonatis
>........
>
>Merged revisions 380331 from http://svn.asterisk.org/svn/asterisk/branches/11
>



--------------
Tests
--------------
New Test Failures (1)
   - AsteriskTestSuite: S/bridge/connected line update

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20130129/993ddc14/attachment.htm>