[test-results] [Bamboo] Asterisk Testing > Asterisk 1.8 Branch > #518 was SUCCESSFUL (with 187 tests). Change made by Matthew Jordan.

[Bamboo]

-----------------------------------------------------------------------
Asterisk Testing > Asterisk 1.8 Branch > #518 was successful.
-----------------------------------------------------------------------
Code has been updated by Matthew Jordan.
187 tests in total.

http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-518/


--------------
Code Changes
--------------
Matthew Jordan (378269):

>Resolve crashes due to large stack allocations when using TCP
>
>Asterisk had several places where messages received over various network
>transports may be copied in a single stack allocation. In the case of TCP,
>since multiple packets in a stream may be concatenated together, this can
>lead to large allocations that overflow the stack.
>
>This patch modifies those portions of Asterisk using TCP to either
>favor heap allocations or use an upper bound to ensure that the stack will not
>overflow:
> * For SIP, the allocation now has an upper limit
> * For HTTP, the allocation is now a heap allocation instead of a stack
>   allocation
> * For XMPP (in res_jabber), the allocation has been eliminated since it was
>   unnecesary.
>
>Note that the HTTP portion of this issue was independently found by Brandon
>Edwards of Exodus Intelligence.
>
>(issue ASTERISK-20658)
>Reported by: wdoekes, Brandon Edwards
>Tested by: mmichelson, wdoekes
>patches:
>  ASTERISK-20658_res_jabber.c.patch uploaded by mmichelson (license 5049)
>  issueA20658_http_postvars_use_malloc2.patch uploaded by wdoekes (license 5674)
>  issueA20658_limit_sip_packet_size3.patch uploaded by wdoekes (license 5674)
>
>



--------------
Tests
--------------
Fixed Tests (1)
   - AsteriskTestSuite: S/cdr/batch cdrs

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20130102/5acd497d/attachment.htm>