[test-results] [Bamboo] Asterisk Testing > Asterisk 11 Branch > #60 was SUCCESSFUL (with 285 tests). Change made by Matthew Jordan.

[Bamboo]

-----------------------------------------------------------------------
Asterisk Testing > Asterisk 11 Branch > #60 was successful.
-----------------------------------------------------------------------
Code has been updated by Matthew Jordan.
285 tests in total.

http://bamboo.asterisk.org/browse/TESTING-AST11BRANCH-60/


--------------
Code Changes
--------------
Matthew Jordan (372583):

>Free ast_str objects when temp file fails to be created in MiniVM
>
>The previous commit (r372554) was from a patch that was written before
>r366880, which ensured that ast_str objects allocated in the sendmail
>routine were free'd in off nominal paths.  This commit frees the
>string objects in the off nominal path introduced in r372554.
>
>(issue ASTERISK-17133)
>Reported by: Tzafrir Cohen
>........
>
>Merged revisions 372581 from http://svn.asterisk.org/svn/asterisk/branches/1.8
>........
>
>Merged revisions 372582 from http://svn.asterisk.org/svn/asterisk/branches/10
>

Matthew Jordan (372556):

>Fix file descriptor leak and pointer scope issue in MiniVM when sending mail
>
>When MiniVM sends an e-mail and it has the volgain option set, it will spawn
>sox in a separate process to handle the manipulation of the sound file.  In
>doing so, it creates a temporary file.  There are two problems here:
>  1) The file descriptor returned from mkstemp is leaked
>  2) The finalfilename character pointer points to a buffer that loses scope
>     once volgain processing is finished.
>
>Note that in r316265, Russell fixed some gcc warnings by using the return
>value of the mkstemp call.  A warning was placed in minivm that the file
>descriptor was going to be leaked.  This patch reverts that change, as it
>handles the leak and 'uses' the file descriptor returned from mkstemp.
>
>(closes issue ASTERISK-17133)
>Reported by: Tzafrir Cohen
>patches:
>  minivm_18501_demo.diff uploaded by Tzafrir Cohen (license #5035)
>........
>
>Merged revisions 372554 from http://svn.asterisk.org/svn/asterisk/branches/1.8
>........
>
>Merged revisions 372555 from http://svn.asterisk.org/svn/asterisk/branches/10
>



--------------
Tests
--------------
Fixed Tests (2)
   - AsteriskTestSuite: S/channels/ s i p/ s d p attribute passthrough
   - AsteriskTestSuite: S/pbx/pbx lua goto

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20120908/42fcfec9/attachment.htm>