[test-results] [Bamboo] Asterisk Testing > Asterisk 10 Branch > #432 has FAILED (2 tests failed). Change made by Mark Michelson.

Bamboo bamboo at asterisk.org
Mon Oct 15 11:26:29 CDT 2012


-----------------------------------------------------------------------
Asterisk Testing > Asterisk 10 Branch > #432 failed.
-----------------------------------------------------------------------
Code has been updated by Mark Michelson.
2/221 tests failed.

http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-432/


--------------
Failing Jobs
--------------
  - Asterisk CentOS 6 64-Bit (CentOS 6): 2 of 221 tests failed.



--------------
Code Changes
--------------
Mark Michelson (374906):

>Do not use a FILE handle when doing SIP TCP reads.
>
>This is used to solve an issue where a poll on a file
>descriptor does not necessarily correspond to the readiness
>of a FILE handle to be read.
>
>This change makes it so that for TCP connections, we do a
>recv() on the file descriptor instead.
>
>Because TCP does not guarantee that an entire message or even
>just one single message will arrive during a read, a loop has
>been introduced to ensure that we only attempt to handle a
>single message at a time. The tcptls_session_instance structure
>has also had an overflow buffer added to it so that if more
>than one TCP message arrives in one go, there is a place to
>throw the excess.
>
>Huge thanks goes out to Walter Doekes for doing extensive review
>on this change and finding edge cases where code could fail.
>
>(closes issue ASTERISK-20212)
>reported by Phil Ciccone
>
>Review: https://reviewboard.asterisk.org/r/2123
>........
>
>Merged revisions 374905 from http://svn.asterisk.org/svn/asterisk/branches/1.8
>



--------------
Tests
--------------
New Test Failures (2)
   - AsteriskTestSuite: S/channels/ s i p/sip attended transfer tcp
   - AsteriskTestSuite: S/channels/ s i p/sip outbound address

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20121015/ed915997/attachment.htm>


More information about the Test-results mailing list