[test-results] [Bamboo] Asterisk Testing > Asterisk Trunk > #735 was SUCCESSFUL (with 291 tests). Change made by dlee.
Bamboo
bamboo at asterisk.org
Sat Oct 6 12:22:11 CDT 2012
-----------------------------------------------------------------------
Asterisk Testing > Asterisk Trunk > #735 was successful.
-----------------------------------------------------------------------
Code has been updated by dlee.
291 tests in total.
http://bamboo.asterisk.org/browse/TESTING-ASTERISKTRUNK-735/
--------------
Code Changes
--------------
dlee (374588):
>Multiple revisions 374570,374581
>
>........
> r374570 | dlee | 2012-10-05 15:14:41 -0500 (Fri, 05 Oct 2012) | 22 lines
>
> Improve AMI long line error handling
>
> In AMI's parser, when it receives a long line (> 1024 characters), it discards
> that line, but continues to process the message normally.
>
> Typically, this is not a problem because a) who has lines that long and b)
> usually a discarded line results in an invalid message. But if that line is
> specifying an optional field, then the message will be processed, you get a
> 'Response: Success', but things don't work the way you expected them to.
>
> This patch changes the behavior when a line-too-long parse error occurs.
>
> * Changes the log message to avoid way-too-long (and truncated anyways) log
> messages
> * Adds a 'parsing' status flag to Response: Success
> * Sets parsing = MESSAGE_LINE_TOO_LONG if, well, a line is too long
> * Responds with an appropriate error if parsing != MESSAGE_OKAY
>
> (closes issue AST-961)
> Reported by: John Bigelow
> Review: https://reviewboard.asterisk.org/r/2142/
>........
> r374581 | dlee | 2012-10-05 15:20:28 -0500 (Fri, 05 Oct 2012) | 1 line
>
> I've committed too much. Reverting part of r374570.
>........
>
>Merged revisions 374570,374581 from http://svn.asterisk.org/svn/asterisk/branches/1.8
>........
>
>Merged revisions 374586 from http://svn.asterisk.org/svn/asterisk/branches/10
>........
>
>Merged revisions 374587 from http://svn.asterisk.org/svn/asterisk/branches/11
>
--------------
Tests
--------------
Fixed Tests (1)
- AsteriskTestSuite: S/channels/ s i p/sip outbound address
--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20121006/b8424ea6/attachment.htm>
More information about the Test-results
mailing list