[test-results] [Bamboo] Asterisk - Team Branches > Asterisk Trunk DigiumPhones > #363 has FAILED. Change made by Matthew Jordan.
Bamboo
bamboo at asterisk.org
Thu May 24 20:13:14 CDT 2012
-----------------------------------------------------------------------
Asterisk - Team Branches > Asterisk Trunk DigiumPhones > #363 failed.
-----------------------------------------------------------------------
Code has been updated by Matthew Jordan.
No failed tests found, a possible compilation error.
http://bamboo.asterisk.org/browse/ASTTEAM-ASTERISKTRUNKDIGIUMPHONES-363/
--------------
Failing Jobs
--------------
- Asterisk CentOS 6 64-Bit (CentOS 6): 93 tests passed.
--------------
Code Changes
--------------
Matthew Jordan (367563):
>Fix crash in ConfBridge when user announcement is played for more than 2 users
>
>A patch introduced in r354938 made it so that ConfBridge would not attempt to
>play sound files if those files did not exist. Unfortunately, ConfBridge uses
>the same underlying function, play_sound_helper, to playback both sound files
>and numbers to callers. When a number is being played back, the name of the
>sound file is expected to be NULL. This NULL value was passed into a function
>that tested for the existance of a sound file and is not tolerant to NULL
>file names, causing a crash.
>
>This patch fixes the behavior, such that if a sound file does not exist we
>do not attempt to play it, but we only attempt that check if the a sound file
>was specified in the first place. If a sound file was not specified, we use
>the 'play number' logic in the helper function.
>
>(closes issue ASTERISK-19899)
>Reported by: Florian Gilcher
>Tested by: Florian Gilcher
>patches:
> asterisk-19899.diff uploaded by mjordan (license 6283)
>........
>
>Merged revisions 367562 from http://svn.asterisk.org/svn/asterisk/branches/10
>
--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20120524/ef97688a/attachment.htm>
More information about the Test-results
mailing list